arm64: Add a CPU reset hook instead of expecting PSCI
ClosedPublic
Actions

Authored by stevek on Mar 27 2024, 9:18 PM.

Details

Reviewers

andrew
manu

Commits

rG3bbe8ed1a7dc: arm64: Add a CPU reset hook instead of expecting PSCI

Summary

Some SoCs do not include a PSCI for power management and defer it to
something else instead. Add a CPU reset hook to account for this, and
use it in the psci driver.

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

stevek created this revision.Mar 27 2024, 9:18 PM

Herald added a reviewer: manu. · View Herald TranscriptMar 27 2024, 9:18 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

stevek requested review of this revision.Mar 27 2024, 9:18 PM

Harbormaster completed remote builds in B56810: Diff 136282.Mar 27 2024, 9:18 PM

Is there a reason to not have cpu_reset_hook = psci_reset by default so we can remove the NULL check?

In D44535#1015791, @andrew wrote:

Is there a reason to not have cpu_reset_hook = psci_reset by default so we can remove the NULL check?

Given that psci.c is "standard" on arm64 and it will not do anything until/unless it probes/attaches (and thus psci_softc is non-NULL), yes, I believe it could just default to psci_reset (maybe with a comment stating the reasons why?)

Updated based on review comments

Harbormaster completed remote builds in B56823: Diff 136313.Mar 28 2024, 7:05 PM

andrew accepted this revision.Apr 4 2024, 11:10 AM

This revision is now accepted and ready to land.Apr 4 2024, 11:10 AM

Closed by commit rG3bbe8ed1a7dc: arm64: Add a CPU reset hook instead of expecting PSCI (authored by stevek). · Explain WhyApr 5 2024, 9:38 PM

This revision was automatically updated to reflect the committed changes.

stevek added a commit: rG3bbe8ed1a7dc: arm64: Add a CPU reset hook instead of expecting PSCI.

jhibbits mentioned this in D32804: Add a CPU reset hook to arm64.Apr 5 2024, 11:15 PM