Paths

Table of Contentst

Differential D44150

mbuf: provide mc_uiotomc() a function to copy from uio(9) to mchain
ClosedPublic
Actions

Authored by glebius on Feb 29 2024, 7:03 AM.

Tags

None

Referenced Files

	F167913341: D44150.id135951.diff
	Tue, Aug 25, 9:57 AM

	F167902677: D44150.id.diff
	Tue, Aug 25, 8:45 AM

	F167897057: D44150.id136738.diff
	Tue, Aug 25, 7:58 AM

	F167892165: D44150.id135209.diff
	Tue, Aug 25, 7:17 AM

	F167889408: D44150.id135828.diff
	Tue, Aug 25, 6:52 AM

	F167881928: D44150.diff
	Tue, Aug 25, 5:45 AM

	Unknown Object (File)
	Sun, Aug 23, 4:03 PM

	Unknown Object (File)
	Fri, Aug 21, 3:51 PM

Subscribers

Details

Reviewers

tuexen
markj

Group Reviewers

transport
network

Commits

rGaba79b0f4a3f: mbuf: provide mc_uiotomc() a function to copy from uio(9) to mchain

Summary

Implement m_uiotombuf() as a wrapper around mc_uiotomc(). The M_EXTPG is
left untouched. The m_uiotombuf() is left as a compat KPI. New code
should use either mc_uiotomc() or m_uiotombuf_nomap().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56648
Build 53536: arc lint + arc unit

Event Timeline

glebius created this revision.Feb 29 2024, 7:03 AM

Herald added subscribers: olce, imp. · View Herald TranscriptFeb 29 2024, 7:03 AM

glebius requested review of this revision.Feb 29 2024, 7:03 AM

glebius added a parent revision: D44149: mbuf: provide mc_get() that allocates struct mchain of given length.

Harbormaster completed remote builds in B56345: Diff 135209.Feb 29 2024, 7:03 AM

glebius added a child revision: D44151: unix: new implementation of unix/stream & unix/seqpacket.Feb 29 2024, 7:03 AM

tuexen accepted this revision.Feb 29 2024, 9:42 AM

This revision is now accepted and ready to land.Feb 29 2024, 9:42 AM

markj added a subscriber: markj.Mar 15 2024, 12:01 PM

markj added inline comments.

sys/kern/uipc_mbuf.c
2015	It would be nice to explain what "len" and "lspace" are.
2023–2024	Can you get rid of `progress` and just use `mc->mc_len`?
2030	What's the purpose of trying to handle the overflow case? We are silently truncating the uio and creating a 4GB chain, which presumably isn't what the caller wants...?

Review from Mark.

This revision now requires review to proceed.Mar 16 2024, 6:11 PM

Harbormaster completed remote builds in B56648: Diff 135828.Mar 16 2024, 6:11 PM

glebius marked 3 inline comments as done.Mar 16 2024, 6:22 PM

markj accepted this revision as: markj.Mar 18 2024, 5:28 AM

markj added inline comments.

sys/kern/uipc_mbuf.c
2000	I'd also assert that `uio->uio_segflg == UIO_WRITE`.

This revision is now accepted and ready to land.Mar 18 2024, 5:28 AM

Utilize mc_first/etc.
Add assertion uio->uio_segflg == UIO_WRITE.

This revision now requires review to proceed.Mar 18 2024, 6:12 PM

Harbormaster completed remote builds in B56678: Diff 135906.Mar 18 2024, 6:12 PM

Correct UIO assertion.

Harbormaster completed remote builds in B56682: Diff 135913.Mar 18 2024, 7:23 PM

markj accepted this revision as: markj.Mar 19 2024, 5:03 AM

markj added inline comments.

sys/kern/uipc_mbuf.c
2000	Sorry, I meant `uio_rw` of course. But why do you assert `segflg == UIO_USERSPACE`? It should be valid for kernel UIOs as well.

This revision is now accepted and ready to land.Mar 19 2024, 5:03 AM

Don't assert uio is from userspace.

This revision now requires review to proceed.Mar 19 2024, 2:56 PM

Harbormaster completed remote builds in B56695: Diff 135951.Mar 19 2024, 2:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 8 2024, 8:30 PM

Closed by commit rGaba79b0f4a3f: mbuf: provide mc_uiotomc() a function to copy from uio(9) to mchain (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGaba79b0f4a3f: mbuf: provide mc_uiotomc() a function to copy from uio(9) to mchain.

Revision Contents
Changeset List

Path

Size

sys/

kern/

127 lines

sys/

1 line

Diff 135828

sys/kern/uipc_mbuf.c

Loading...

sys/sys/mbuf.h

Loading...