Differential D41118

arm64/riscv pmap: Initialize the pmap's pm_pvchunk field
ClosedPublic
Actions

Authored by alc on Jul 20 2023, 5:29 PM.

Tags

None

Referenced Files

	F170578573: D41118.id.diff
	Sat, Sep 5, 12:05 PM

	F170575647: D41118.id124924.diff
	Sat, Sep 5, 11:44 AM

	F170507396: D41118.id125020.diff
	Sat, Sep 5, 3:51 AM

	F170450596: D41118.id125020.diff
	Fri, Sep 4, 9:35 PM

	Unknown Object (File)
	Thu, Sep 3, 8:51 PM

	Unknown Object (File)
	Thu, Sep 3, 3:34 AM

	Unknown Object (File)
	Wed, Sep 2, 2:49 PM

	Unknown Object (File)
	Wed, Sep 2, 8:40 AM

Subscribers

Details

Reviewers

kib
markj
andrew
manu

Commits

rG29edff0dea0f: arm64/riscv pmap: Initialize the pmap's pm_pvchunk field

Summary

From reading the code, I believe that the reasons that the missing TAILQ_INIT()s haven't caused a problem are two-fold: The first field is being initialized to zeroes elsewhere, and the first access to the last field is by TAILQ_INSERT_HEAD(), which sets it because the first field is NULL.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alc created this revision.Jul 20 2023, 5:29 PM

Herald added a reviewer: andrew. · View Herald TranscriptJul 20 2023, 5:29 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: riscv, emaste. · View Herald Transcript

alc requested review of this revision.Jul 20 2023, 5:29 PM

kib accepted this revision.Jul 20 2023, 5:48 PM

This revision is now accepted and ready to land.Jul 20 2023, 5:48 PM

markj accepted this revision.Jul 21 2023, 2:06 PM

Closed by commit rG29edff0dea0f: arm64/riscv pmap: Initialize the pmap's pm_pvchunk field (authored by alc). · Explain WhyJul 22 2023, 4:59 AM

This revision was automatically updated to reflect the committed changes.

alc added a commit: rG29edff0dea0f: arm64/riscv pmap: Initialize the pmap's pm_pvchunk field.

Herald added a subscriber: imp. · View Herald TranscriptJul 22 2023, 4:59 AM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

arm64/

3 lines

riscv/

riscv/

3 lines

Diff 125020

sys/arm64/arm64/pmap.c

Loading...

sys/riscv/riscv/pmap.c

Loading...