From reading the code, I believe that the reasons that the missing TAILQ_INIT()s haven't caused a problem are two-fold: The first field is being initialized to zeroes elsewhere, and the first access to the last field is by TAILQ_INSERT_HEAD(), which sets it because the first field is NULL.
Details
Details
Summary
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Herald added a reviewer: andrew. · View Herald TranscriptJul 20 2023, 5:29 PM2023-07-20 17:29:05 (UTC+0)
This revision is now accepted and ready to land.Jul 20 2023, 5:48 PM2023-07-20 17:48:59 (UTC+0)
Closed by commit rG29edff0dea0f: arm64/riscv pmap: Initialize the pmap's pm_pvchunk field (authored by alc). · Explain WhyJul 22 2023, 4:59 AM2023-07-22 04:59:32 (UTC+0)
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptJul 22 2023, 4:59 AM2023-07-22 04:59:33 (UTC+0)