Add null check to iflib_stop()
ClosedPublic
Actions

Authored by przemyslawx.lewandowski_intel.com on Dec 28 2022, 8:31 AM.

Details

Reviewers

avg
marius
scottl
pkubaj
kgalazka
erj
shurd

Group Reviewers

iflib

Commits

rGc907f13af0e6: iflib: Add null check to iflib_stop()
rG4ad47cfc1458: iflib: Add null check to iflib_stop()
rG9147969bc277: iflib: Add null check to iflib_stop()

Summary

Since gtaskqueue_drain was added to iflib_stop() then panic kernel occurs when intel ice driver is in recovery mode. Queues are not initialized in this mode so gt_taskqueue is not initialized as well. Added if condition fixes this issue.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

przemyslawx.lewandowski_intel.com created this revision.Dec 28 2022, 8:31 AM

Herald added a reviewer: shurd. · View Herald TranscriptDec 28 2022, 8:31 AM

Herald added a reviewer: iflib. · View Herald Transcript

Herald added subscribers: glebius, melifaro, ae. · View Herald Transcript

przemyslawx.lewandowski_intel.com requested review of this revision.Dec 28 2022, 8:31 AM

I think this looks good.

erj accepted this revision.Jan 24 2023, 11:43 PM

This revision is now accepted and ready to land.Jan 24 2023, 11:43 PM

Closed by commit rG9147969bc277: iflib: Add null check to iflib_stop() (authored by przemyslawx.lewandowski_intel.com, committed by erj). · Explain WhyJan 24 2023, 11:46 PM

This revision was automatically updated to reflect the committed changes.

erj added a commit: rG9147969bc277: iflib: Add null check to iflib_stop().

Herald added a subscriber: imp. · View Herald TranscriptJan 24 2023, 11:46 PM

erj added a commit: rG4ad47cfc1458: iflib: Add null check to iflib_stop().Feb 7 2023, 12:16 AM

erj added a commit: rGc907f13af0e6: iflib: Add null check to iflib_stop().Feb 7 2023, 12:32 AM

Revision Contents
Changeset List

Path

Size

sys/

net/

iflib.c

5 lines

Diff 115704

View Options

Add null check to iflib_stop()ClosedPublicActions