Page MenuHomeFreeBSD
Differential D37732

jail: Fix output of IPv[46] addresses of DDB `show prison`
ClosedPublic
Actions

Authored by zlei on Dec 18 2022, 11:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 10, 7:43 PM
Unknown Object (File)
Thu, Dec 4, 9:36 AM
Unknown Object (File)
Wed, Nov 26, 11:13 AM
Unknown Object (File)
Thu, Nov 20, 7:24 AM
Unknown Object (File)
Nov 19 2025, 12:04 AM
Unknown Object (File)
Nov 13 2025, 9:25 PM
Unknown Object (File)
Nov 13 2025, 5:22 AM
Unknown Object (File)
Nov 13 2025, 3:03 AM
View All Files
Subscribers
imp

Details

Reviewers
glebius
jamie
kp
melifaro
Commits
rG21ad3e27fabc: jail: Fix output of IPv[46] addresses of DDB `show prison`
Summary

Fixes: eb8dcdeac22d jail: network epoch protection for IP address lists

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei created this revision.Dec 18 2022, 11:09 AM
Herald added a subscriber: imp. · View Herald TranscriptDec 18 2022, 11:09 AM
zlei requested review of this revision.Dec 18 2022, 11:09 AM
zlei added reviewers: kp, melifaro.
melifaro accepted this revision.Dec 18 2022, 2:52 PM

LGTM!
Do you think it would be possible to convert PR_IP to be static inline function, so that kind of erros are spotted by the compiler?

This revision is now accepted and ready to land.Dec 18 2022, 2:52 PM
zlei added a comment.Dec 18 2022, 3:21 PM
In D37732#858183, @melifaro wrote:

LGTM!
Do you think it would be possible to convert PR_IP to be static inline function, so that kind of erros are spotted by the compiler?

I'll take a look at that. Smart compilers help a lot ;)

zlei retitled this revision from jail: Fix output of IPv[4,6] addresses of DDB `show prison` to jail: Fix output of IPv[46] addresses of DDB `show prison`.Dec 18 2022, 4:13 PM
zlei edited the summary of this revision. (Show Details)
jamie accepted this revision.Dec 18 2022, 5:32 PM
kp added a comment.Dec 18 2022, 7:47 PM

Approved by: kp (mentor)

Closed by commit rG21ad3e27fabc: jail: Fix output of IPv[46] addresses of DDB `show prison` (authored by zlei). · Explain WhyDec 21 2022, 1:59 AM
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rG21ad3e27fabc: jail: Fix output of IPv[46] addresses of DDB `show prison`.
zlei mentioned this in D37874: jail: Use flexible array member within struct prison_ip.Dec 25 2022, 6:59 PM
zlei added a comment.Dec 25 2022, 7:04 PM
In D37732#858186, @zlei wrote:
In D37732#858183, @melifaro wrote:

LGTM!
Do you think it would be possible to convert PR_IP to be static inline function, so that kind of erros are spotted by the compiler?

I'll take a look at that. Smart compilers help a lot ;)

Please see D37874 .

Revision Contents
Changeset List

PathSize
sys/
kern/
4 lines

Diff 114247

View Options

sys/kern/kern_jail.c

Loading...