Page MenuHomeFreeBSD

jail: Fix output of IPv[46] addresses of DDB `show prison`
ClosedPublic

Authored by zlei on Dec 18 2022, 11:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 2, 11:39 PM
Unknown Object (File)
Wed, Oct 2, 8:00 AM
Unknown Object (File)
Tue, Oct 1, 5:16 AM
Unknown Object (File)
Tue, Oct 1, 3:36 AM
Unknown Object (File)
Mon, Sep 30, 4:31 PM
Unknown Object (File)
Mon, Sep 30, 4:11 PM
Unknown Object (File)
Fri, Sep 27, 2:57 PM
Unknown Object (File)
Fri, Sep 27, 1:08 PM
Subscribers

Details

Summary

Fixes: eb8dcdeac22d jail: network epoch protection for IP address lists

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei requested review of this revision.Dec 18 2022, 11:09 AM
zlei added reviewers: kp, melifaro.

LGTM!
Do you think it would be possible to convert PR_IP to be static inline function, so that kind of erros are spotted by the compiler?

This revision is now accepted and ready to land.Dec 18 2022, 2:52 PM

LGTM!
Do you think it would be possible to convert PR_IP to be static inline function, so that kind of erros are spotted by the compiler?

I'll take a look at that. Smart compilers help a lot ;)

zlei retitled this revision from jail: Fix output of IPv[4,6] addresses of DDB `show prison` to jail: Fix output of IPv[46] addresses of DDB `show prison`.Dec 18 2022, 4:13 PM
zlei edited the summary of this revision. (Show Details)
In D37732#858186, @zlei wrote:

LGTM!
Do you think it would be possible to convert PR_IP to be static inline function, so that kind of erros are spotted by the compiler?

I'll take a look at that. Smart compilers help a lot ;)

Please see D37874 .