Page MenuHomeFreeBSD
Differential D37732

jail: Fix output of IPv[46] addresses of DDB `show prison`
ClosedPublic
Actions

Authored by zlei on Dec 18 2022, 11:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 2, 11:39 PM
Unknown Object (File)
Wed, Oct 2, 8:00 AM
Unknown Object (File)
Tue, Oct 1, 5:16 AM
Unknown Object (File)
Tue, Oct 1, 3:36 AM
Unknown Object (File)
Mon, Sep 30, 4:31 PM
Unknown Object (File)
Mon, Sep 30, 4:11 PM
Unknown Object (File)
Fri, Sep 27, 2:57 PM
Unknown Object (File)
Fri, Sep 27, 1:08 PM
View All 61 Files
Subscribers
imp

Details

Reviewers
glebius
jamie
kp
melifaro
Commits
rG21ad3e27fabc: jail: Fix output of IPv[46] addresses of DDB `show prison`
Summary

Fixes: eb8dcdeac22d jail: network epoch protection for IP address lists

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei created this revision.Dec 18 2022, 11:09 AM
Herald added a subscriber: imp. · View Herald TranscriptDec 18 2022, 11:09 AM
zlei requested review of this revision.Dec 18 2022, 11:09 AM
zlei added reviewers: kp, melifaro.
melifaro accepted this revision.Dec 18 2022, 2:52 PM

LGTM!
Do you think it would be possible to convert PR_IP to be static inline function, so that kind of erros are spotted by the compiler?

This revision is now accepted and ready to land.Dec 18 2022, 2:52 PM
zlei added a comment.Dec 18 2022, 3:21 PM
In D37732#858183, @melifaro wrote:

LGTM!
Do you think it would be possible to convert PR_IP to be static inline function, so that kind of erros are spotted by the compiler?

I'll take a look at that. Smart compilers help a lot ;)

zlei retitled this revision from jail: Fix output of IPv[4,6] addresses of DDB `show prison` to jail: Fix output of IPv[46] addresses of DDB `show prison`.Dec 18 2022, 4:13 PM
zlei edited the summary of this revision. (Show Details)
jamie accepted this revision.Dec 18 2022, 5:32 PM
kp added a comment.Dec 18 2022, 7:47 PM

Approved by: kp (mentor)

Closed by commit rG21ad3e27fabc: jail: Fix output of IPv[46] addresses of DDB `show prison` (authored by zlei). · Explain WhyDec 21 2022, 1:59 AM
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rG21ad3e27fabc: jail: Fix output of IPv[46] addresses of DDB `show prison`.
zlei mentioned this in D37874: jail: Use flexible array member within struct prison_ip.Dec 25 2022, 6:59 PM
zlei added a comment.Dec 25 2022, 7:04 PM
In D37732#858186, @zlei wrote:
In D37732#858183, @melifaro wrote:

LGTM!
Do you think it would be possible to convert PR_IP to be static inline function, so that kind of erros are spotted by the compiler?

I'll take a look at that. Smart compilers help a lot ;)

Please see D37874 .

Revision Contents
Changeset List

PathSize
sys/
kern/
4 lines

Diff 114350

View Options

sys/kern/kern_jail.c

Loading...