tcp: make tcp_handle_wakeup() static and robust
ClosedPublic
Actions

Authored by glebius on Oct 25 2022, 12:57 AM.

Details

Reviewers

rscheff
tuexen

Group Reviewers

transport

Commits

rGc348e8805365: tcp: make tcp_handle_wakeup() static and robust

Summary

It is called only from tcp_input() and always has valid parameter.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47983
Build 44870: arc lint + arc unit

Event Timeline

glebius created this revision.Oct 25 2022, 12:57 AM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptOct 25 2022, 12:57 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

Harbormaster completed remote builds in B47983: Diff 112172.Oct 25 2022, 12:57 AM

glebius requested review of this revision.Oct 25 2022, 12:57 AM

Thanks for the simplification (in earlier iterations, calling this function was not safe..)

This revision is now accepted and ready to land.Oct 25 2022, 9:58 AM

tuexen accepted this revision.Oct 25 2022, 10:29 AM

glebius added a child revision: D37123: tcp: provide macros to access inpcb and socket from a tcpcb.Oct 25 2022, 6:20 PM

glebius added a child revision: D37127: tcp: embed inpcb into tcpcb.Oct 25 2022, 7:01 PM

Closed by commit rGc348e8805365: tcp: make tcp_handle_wakeup() static and robust (authored by glebius). · Explain WhyOct 31 2022, 3:58 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGc348e8805365: tcp: make tcp_handle_wakeup() static and robust.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_input.c

25 lines

tcp_var.h

1 line

Diff 112172

View Options

sys/netinet/tcp_input.c