Page MenuHomeFreeBSD

inpcb: don't return INP_DROPPED entries from pcb lookups
ClosedPublic

Authored by glebius on Oct 19 2022, 10:22 PM.
Tags
None
Referenced Files
F142212455: D37061.id112012.diff
Sat, Jan 17, 7:53 AM
F142206652: D37061.id.diff
Sat, Jan 17, 5:52 AM
F142183628: D37061.diff
Fri, Jan 16, 10:48 PM
F142174046: D37061.diff
Fri, Jan 16, 7:37 PM
Unknown Object (File)
Wed, Jan 14, 11:38 AM
Unknown Object (File)
Tue, Jan 13, 1:12 AM
Unknown Object (File)
Nov 28 2025, 12:23 AM
Unknown Object (File)
Nov 27 2025, 3:14 AM

Details

Summary

The in_pcbdrop() KPI, which is used solely by TCP, allows to remove a
pcb from hash list and mark it as dropped. The comment suggests that
such pcb won't be returned by lookups. Indeed, every call to
in_pcblookup*() is accompanied by a check for INP_DROPPED. Do what
comment suggests: never return such pcbs and remove unnecessary checks.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen added inline comments.
sys/netinet/tcp_lro.c
1362

Maybe also remove the comment?

sys/netinet/tcp_lro.c
1362

It still applies to the (tp == NULL) check. Which is going to be addressed later, and that would remove the comment, too.

This revision is now accepted and ready to land.Oct 20 2022, 9:27 AM