Tags

None

Referenced Files

	F167998984: D37115.id.diff
	Tue, Aug 25, 8:33 PM

	F167991045: D37115.diff
	Tue, Aug 25, 7:22 PM

	F167891631: D37115.id112172.diff
	Tue, Aug 25, 7:12 AM

	Unknown Object (File)
	Sun, Aug 23, 11:59 PM

	Unknown Object (File)
	Sun, Aug 23, 8:04 PM

	Unknown Object (File)
	Sun, Aug 23, 7:48 PM

	Unknown Object (File)
	Thu, Aug 13, 6:43 PM

	Unknown Object (File)
	Wed, Aug 12, 5:36 PM

Subscribers

Details

Reviewers

rscheff
tuexen

Group Reviewers

transport

Commits

rGc348e8805365: tcp: make tcp_handle_wakeup() static and robust

Summary

It is called only from tcp_input() and always has valid parameter.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Oct 25 2022, 12:57 AM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptOct 25 2022, 12:57 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

Harbormaster completed remote builds in B47983: Diff 112172.Oct 25 2022, 12:57 AM

glebius requested review of this revision.Oct 25 2022, 12:57 AM

Thanks for the simplification (in earlier iterations, calling this function was not safe..)

This revision is now accepted and ready to land.Oct 25 2022, 9:58 AM

tuexen accepted this revision.Oct 25 2022, 10:29 AM

glebius added a child revision: D37123: tcp: provide macros to access inpcb and socket from a tcpcb.Oct 25 2022, 6:20 PM

glebius added a child revision: D37127: tcp: embed inpcb into tcpcb.Oct 25 2022, 7:01 PM

Closed by commit rGc348e8805365: tcp: make tcp_handle_wakeup() static and robust (authored by glebius). · Explain WhyOct 31 2022, 3:58 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGc348e8805365: tcp: make tcp_handle_wakeup() static and robust.

tcp: make tcp_handle_wakeup() static and robust
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 112442

sys/netinet/tcp_input.c

sys/netinet/tcp_var.h

tcp: make tcp_handle_wakeup() static and robustClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 112442

sys/netinet/tcp_input.c

sys/netinet/tcp_var.h

tcp: make tcp_handle_wakeup() static and robust
ClosedPublic
Actions

Revision Contents
Changeset List