Page MenuHomeFreeBSD
Differential D35925

stand: userboot_fmtdev can be reduced to devformat
ClosedPublic
Actions

Authored by imp on Jul 25 2022, 8:34 PM.
Tags
None
Referenced Files
F109462990: D35925.id108663.diff
Wed, Feb 5, 9:44 AM
Unknown Object (File)
Sat, Jan 18, 11:07 AM
Unknown Object (File)
Sat, Jan 18, 11:01 AM
Unknown Object (File)
Sat, Jan 18, 10:46 AM
Unknown Object (File)
Sat, Jan 18, 8:01 AM
Unknown Object (File)
Fri, Jan 17, 6:29 PM
Unknown Object (File)
Fri, Jan 17, 6:33 AM
Unknown Object (File)
Fri, Jan 17, 6:32 AM
View All 79 Files
Subscribers
dab
rgrimes

Details

Reviewers
tsoome
kevans
manu
jhb
Group Reviewers
bhyve
Commits
rGe36bd9b6cffb: stand: userboot_fmtdev can be reduced to devformat
rG1e9b23448a30: stand: userboot_fmtdev can be reduced to devformat
Summary

devformat produces the same output as userboot_fmtdev, so just use it to
reduce on the dependencies.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Jul 25 2022, 8:34 PM
Herald added a reviewer: manu. · View Herald TranscriptJul 25 2022, 8:34 PM
Herald added a reviewer: bhyve. · View Herald Transcript
Herald added subscribers: dab, rgrimes. · View Herald Transcript
imp requested review of this revision.Jul 25 2022, 8:34 PM
Harbormaster completed remote builds in B46570: Diff 108521.Jul 25 2022, 8:34 PM
imp added a parent revision: D35924: stand: efi_fmtdev can be reduced to devformat.Jul 25 2022, 8:34 PM
imp added a child revision: D35926: stand: uboot_fmtdev can be reduced to devformat.
jhb accepted this revision.Jul 27 2022, 10:27 PM
This revision is now accepted and ready to land.Jul 27 2022, 10:27 PM
imp updated this revision to Diff 108663.Jul 28 2022, 5:00 PM

rework based on feedback, and correct a few closely related nits

This revision now requires review to proceed.Jul 28 2022, 5:00 PM
Harbormaster completed remote builds in B46656: Diff 108663.Jul 28 2022, 5:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 11 2022, 4:28 PM
Closed by commit rG1e9b23448a30: stand: userboot_fmtdev can be reduced to devformat (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG1e9b23448a30: stand: userboot_fmtdev can be reduced to devformat.
imp added a commit: rGe36bd9b6cffb: stand: userboot_fmtdev can be reduced to devformat.Jan 24 2023, 10:16 PM

Revision Contents
Changeset List

PathSize
stand/
userboot/
userboot/
6 lines
4 lines
34 lines
1 line
2 lines

Diff 109189

View Options

stand/userboot/userboot/bootinfo32.c

Loading...
View Options

stand/userboot/userboot/bootinfo64.c

Loading...
View Options

stand/userboot/userboot/devicename.c

Loading...
View Options

stand/userboot/userboot/libuserboot.h

Loading...
View Options

stand/userboot/userboot/main.c

Loading...