rtsock: subscribe to ifnet eventhandlers instead of direct calls.
ClosedPublic
Actions

Authored by melifaro on Aug 9 2022, 9:08 PM.

Details

Reviewers

Group Reviewers

Commits

rGf5de03cb2c69: rtsock: subscribe to ifnet eventhandlers instead of direct calls.
rGd8b42ddcac5c: rtsock: subscribe to ifnet eventhandlers instead of direct calls.

Summary

Stop treating rtsock as a "special" consumer and use already-provided
ifaddr arrival/departure notifications.

MFC after: 2 weeks

Test Plan

21:05 [0] m@devel0 route -n monitor

-> ifconfig vtnet0.2 create

got message of size 24 on Tue Aug  9 21:05:44 2022
RTM_IFANNOUNCE: interface arrival/departure: len 24, if# 3, what: arrival

got message of size 168 on Tue Aug  9 21:05:54 2022
RTM_IFINFO: iface status change: len 168, if# 3, link: up, flags:<BROADCAST,RUNNING,SIMPLEX,MULTICAST>

-> ifconfig vtnet0.2 destroy

got message of size 24 on Tue Aug  9 21:05:54 2022
RTM_IFANNOUNCE: interface arrival/departure: len 24, if# 3, what: departure

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46857
Build 43746: arc lint + arc unit

Event Timeline

melifaro created this revision.Aug 9 2022, 9:08 PM

Herald added subscribers: glebius, ae, imp. · View Herald TranscriptAug 9 2022, 9:08 PM

melifaro requested review of this revision.Aug 9 2022, 9:08 PM

Harbormaster completed remote builds in B46813: Diff 109071.Aug 9 2022, 9:08 PM

melifaro edited the test plan for this revision. (Show Details)Aug 9 2022, 9:10 PM

melifaro added a reviewer: network.

glebius added inline comments.Aug 10 2022, 3:50 PM

sys/net/rtsock.c
288	Just following our today conversation. Here we should either use EVENTHANDLER_DEFINE() or actually implement proper EVENTHANDLER_SYSINIT(). Did you check that EVENTHANDLER_DEFINE() will or will not work here?