Page MenuHomeFreeBSD
Differential D35788

vm: Remove handling for OBJT_DEFAULT objects
ClosedPublic
Actions

Authored by markj on Jul 12 2022, 4:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 4, 4:05 AM
Unknown Object (File)
Sun, Oct 4, 3:47 AM
Unknown Object (File)
Sun, Oct 4, 1:01 AM
Unknown Object (File)
Sat, Oct 3, 11:25 PM
Unknown Object (File)
Fri, Oct 2, 4:50 PM
Unknown Object (File)
Sun, Sep 27, 8:38 AM
Unknown Object (File)
Wed, Sep 9, 11:58 AM
Unknown Object (File)
Sun, Sep 6, 9:58 AM
View All Files
Subscribers
imp

Details

Reviewers
dougm
alc
kib
Commits
rG0cb2610ee2dc: vm: Remove handling for OBJT_DEFAULT objects
Summary

Now that OBJT_DEFAULT objects can't be instantiated, we can simplify
various checks of the form `object->type == OBJT_DEFAULT ||
(object->flags & OBJ_SWAP) != 0`. No functional change intended.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46385
Build 43274: arc lint + arc unit

Event Timeline

markj created this revision.Jul 12 2022, 4:22 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 12 2022, 4:22 PM
markj requested review of this revision.Jul 12 2022, 4:22 PM
Harbormaster completed remote builds in B46385: Diff 108060.Jul 12 2022, 4:23 PM
markj added a parent revision: D35787: vm_object: Release object swap charge in the swap pager destructor.Jul 12 2022, 4:23 PM
markj added a child revision: D35789: vm_object: Remove redundant OBJ_SWAP checks.
kib accepted this revision.Jul 12 2022, 4:55 PM
This revision is now accepted and ready to land.Jul 12 2022, 4:55 PM
alc accepted this revision.Jul 13 2022, 7:51 AM
markj updated this revision to Diff 108097.Jul 13 2022, 1:23 PM

Remove a stale comment from vm_object_split().

This revision now requires review to proceed.Jul 13 2022, 1:23 PM
Harbormaster completed remote builds in B46404: Diff 108097.Jul 13 2022, 1:23 PM
markj mentioned this in D35789: vm_object: Remove redundant OBJ_SWAP checks.Jul 13 2022, 1:25 PM
alc accepted this revision.Jul 13 2022, 3:05 PM
alc added inline comments.
sys/vm/vm_object.c
1528–1529

As an aside, I don't see why we pass a charge to vm_object_allocate_anon(). Currently, the passed charge is always equal to ptoa(size). Moreover, I'm skeptical that there will be a future scenario where it differs.

This revision is now accepted and ready to land.Jul 13 2022, 3:05 PM
Closed by commit rG0cb2610ee2dc: vm: Remove handling for OBJT_DEFAULT objects (authored by markj). · Explain WhyJul 17 2022, 11:26 AM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG0cb2610ee2dc: vm: Remove handling for OBJT_DEFAULT objects.

Revision Contents
Changeset List

PathSize
sys/
vm/
3 lines
12 lines
6 lines
12 lines
6 lines
10 lines

Diff 108060

View Options

sys/vm/vm_fault.c

Loading...
View Options

sys/vm/vm_map.c

Loading...
View Options

sys/vm/vm_mmap.c

Loading...
View Options

sys/vm/vm_object.c

Loading...
View Options

sys/vm/vm_page.c

Loading...
View Options

sys/vm/vm_pageout.c

Loading...