Differential D35384

ifconfig.8: Prefer consistent terminologies
ClosedPublic
Actions

Authored by zlei on Jun 2 2022, 9:48 AM.

Tags

None

Referenced Files

	F109062583: D35384.id106564.diff
	Fri, Jan 31, 7:39 AM

	F109054646: D35384.id106564.diff
	Fri, Jan 31, 5:12 AM

	Unknown Object (File)
	Tue, Jan 28, 7:09 AM

	Unknown Object (File)
	Sat, Jan 25, 5:35 PM

	Unknown Object (File)
	Tue, Jan 21, 8:19 PM

	Unknown Object (File)
	Sat, Jan 18, 11:48 AM

	Unknown Object (File)
	Fri, Jan 17, 8:29 PM

	Unknown Object (File)
	Tue, Jan 14, 2:33 AM

View All 98 Files

Subscribers

Details

Reviewers

0mp
pauamma_gundo.com
email_luiz.eng.br

Group Reviewers

Commits

rG52832592bd7d: ifconfig.8: Prefer consistent terminologies
rGccc48995c2cf: ifconfig.8: Prefer consistent terminologies

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

zlei created this revision.Jun 2 2022, 9:48 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 2 2022, 9:48 AM

zlei requested review of this revision.Jun 2 2022, 9:48 AM

zlei added a child revision: D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.

email_luiz.eng.br accepted this revision.Jun 2 2022, 10:11 AM

This revision is now accepted and ready to land.Jun 2 2022, 10:11 AM

zlei added a reviewer: manpages.Jun 2 2022, 10:42 AM

pauamma_gundo.com requested changes to this revision.Jun 2 2022, 11:11 PM

pauamma_gundo.com added inline comments.

sbin/ifconfig/ifconfig.8
410	Given FreeBSD hasn't supported Token Ring LANs for... IIRC over a decade? I'd remove that while here.

This revision now requires changes to proceed.Jun 2 2022, 11:11 PM

zlei updated this revision to Diff 106650.Jun 6 2022, 2:19 AM

@pauamma_gundo.com And what about the support status of FDDI ? It has been removed via D15017 and D15170 .

zlei added a parent revision: D35409: ifconfig.8: Update to reflect the removal of FDDI and Token Ring media support.Jun 6 2022, 8:12 AM

zlei retitled this revision from ifconfig.8: Prefer consistent terminology to ifconfig.8: Prefer consistent terminologies.

In D35384#802893, @zlei.huang_gmail.com wrote:

@pauamma_gundo.com And what about the support status of FDDI ? It has been removed via D15017 and D15170 .

Ooops, right. Remove FDDI too, then. I only remember FreeBSD TR support going away because I used to ride herd on a several thousand workstations TR network back when 8228s were the latest and greatest.

In D35384#803753, @pauamma_gundo.com wrote:

Ooops, right. Remove FDDI too, then. I only remember FreeBSD TR support going away because I used to ride herd on a several thousand workstations TR network back when 8228s were the latest and greatest.

Or are you planning to do that in D35409 instead?

In D35384#803849, @pauamma_gundo.com wrote:

In D35384#803753, @pauamma_gundo.com wrote:

Ooops, right. Remove FDDI too, then. I only remember FreeBSD TR support going away because I used to ride herd on a several thousand workstations TR network back when 8228s were the latest and greatest.

Or are you planning to do that in D35409 instead?

Yes, I think they are left by D15017 and D15170, so fix it separately.

zlei updated this revision to Diff 106977.Jun 16 2022, 2:20 AM

Ping @pauamma_gundo.com since the parent D35409 has been merged.

pauamma_gundo.com accepted this revision.Jun 17 2022, 1:54 AM

This revision is now accepted and ready to land.Jun 17 2022, 1:54 AM

Hi @0mp , do you have any objections ?

Ping @0mp

Closed by commit rGccc48995c2cf: ifconfig.8: Prefer consistent terminologies (authored by zlei, committed by 0mp). · Explain WhyJun 29 2022, 6:59 AM

This revision was automatically updated to reflect the committed changes.

0mp added a commit: rGccc48995c2cf: ifconfig.8: Prefer consistent terminologies.

@0mp Thanks!

zlei mentioned this in D32820: vxlan: Add support for socket ioctls SIOC[SG]TUNFIB.Jun 29 2022, 10:41 AM

0mp added a commit: rG52832592bd7d: ifconfig.8: Prefer consistent terminologies.Jul 21 2022, 11:57 PM

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

8 lines

Diff 106564

sbin/ifconfig/ifconfig.8

Loading...