Page MenuHomeFreeBSD
Differential D33901

Allow downstream projects to easily add private and internal libs
ClosedPublic
Actions

Authored by vangyzen on Jan 14 2022, 8:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 11, 1:48 PM
Unknown Object (File)
Wed, Sep 9, 8:11 PM
Unknown Object (File)
Tue, Sep 8, 9:21 AM
Unknown Object (File)
Mon, Sep 7, 1:42 AM
Unknown Object (File)
Sun, Sep 6, 8:21 AM
Unknown Object (File)
Sat, Sep 5, 11:56 PM
Unknown Object (File)
Sat, Sep 5, 3:15 PM
Unknown Object (File)
Fri, Sep 4, 11:03 AM
View All Files
Subscribers
badger
dab
emaste
imp

Details

Reviewers
bdrewery
Commits
rG6aac8c390466: Allow downstream projects to easily add private and internal libs
rGd7f944a04605: Allow downstream projects to easily add private and internal libs
Summary

Allow projects based on the FreeBSD tree to append to _PRIVATELIBS
and _INTERNALLIBS by simply maintaining their own lists of
LOCAL_PRIVATELIBS and LOCAL_INTERNALLIBS, respectively.

MFC after: 1 week
Sponsored by: Dell EMC Isilon

Test Plan

This allowed a downstream project to build internal libraries with PIE.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43931
Build 40819: arc lint + arc unit

Event Timeline

vangyzen created this revision.Jan 14 2022, 8:17 PM
Herald added subscribers: dab, badger, emaste, imp. · View Herald TranscriptJan 14 2022, 8:17 PM
vangyzen requested review of this revision.Jan 14 2022, 8:17 PM
Harbormaster completed remote builds in B43929: Diff 101479.Jan 14 2022, 8:17 PM
emaste added a comment.Jan 14 2022, 8:20 PM

This seems reasonable to me, but I think we should have some documentation. Ideally we'd have a man page that documents these sorts of things, but at least a comment in here I'd say.

bdrewery accepted this revision.Jan 14 2022, 8:25 PM
This revision is now accepted and ready to land.Jan 14 2022, 8:25 PM
vangyzen updated this revision to Diff 101482.Jan 14 2022, 8:51 PM
  • CR: add comments
This revision now requires review to proceed.Jan 14 2022, 8:51 PM
Harbormaster completed remote builds in B43931: Diff 101482.Jan 14 2022, 8:51 PM
vangyzen added a comment.Jan 14 2022, 8:52 PM
In D33901#766597, @emaste wrote:

This seems reasonable to me, but I think we should have some documentation. Ideally we'd have a man page that documents these sorts of things, but at least a comment in here I'd say.

Agreed. This is the best I could do. Feel free to suggest something more helpful.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 14 2022, 10:19 PM
Closed by commit rGd7f944a04605: Allow downstream projects to easily add private and internal libs (authored by vangyzen). · Explain Why
This revision was automatically updated to reflect the committed changes.
vangyzen added a commit: rGd7f944a04605: Allow downstream projects to easily add private and internal libs.
vangyzen added a commit: rG6aac8c390466: Allow downstream projects to easily add private and internal libs.Mar 2 2022, 10:00 PM

Revision Contents
Changeset List

PathSize
share/
mk/
8 lines

Diff 101482

View Options

share/mk/src.libnames.mk

Loading...