Page MenuHomeFreeBSD

Allow downstream projects to easily add private and internal libs
ClosedPublic

Authored by vangyzen on Jan 14 2022, 8:17 PM.

Details

Summary

Allow projects based on the FreeBSD tree to append to _PRIVATELIBS
and _INTERNALLIBS by simply maintaining their own lists of
LOCAL_PRIVATELIBS and LOCAL_INTERNALLIBS, respectively.

MFC after: 1 week
Sponsored by: Dell EMC Isilon

Test Plan

This allowed a downstream project to build internal libraries with PIE.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This seems reasonable to me, but I think we should have some documentation. Ideally we'd have a man page that documents these sorts of things, but at least a comment in here I'd say.

This revision is now accepted and ready to land.Jan 14 2022, 8:25 PM
This revision now requires review to proceed.Jan 14 2022, 8:51 PM

This seems reasonable to me, but I think we should have some documentation. Ideally we'd have a man page that documents these sorts of things, but at least a comment in here I'd say.

Agreed. This is the best I could do. Feel free to suggest something more helpful.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 14 2022, 10:19 PM
This revision was automatically updated to reflect the committed changes.