Page MenuHomeFreeBSD
Differential D58047

acpi: parse resources of not-present devices that are kept enabled
Needs ReviewPublic
Actions

Authored by guest-seuros on Sun, Jul 5, 8:45 PM.
Tags
Referenced Files
Unknown Object (File)
Sat, Jul 11, 1:35 AM
Unknown Object (File)
Fri, Jul 10, 11:48 AM
Unknown Object (File)
Fri, Jul 10, 12:37 AM
Unknown Object (File)
Thu, Jul 9, 4:10 AM
Unknown Object (File)
Tue, Jul 7, 4:01 PM
Subscribers
jhb
jkim
ngie
drivers

Details

Reviewers
adrian
imp
Group Reviewers
drivers
Summary

acpi_probe_child() keeps PCI link devices, the RTC,
and docking stations enabled even when _STA reports them not present,
but skipped acpi_parse_resources() for them. With an empty resource
list, resource-based hint matching (BUS_HINT_DEVICE_UNIT) cannot wire
such a device to its hinted unit, and the hinted ISA device is then
created as a duplicate.

Modern AMI firmware reports the PNP0B00 RTC as not present while
handing timekeeping to the ACPI Time-and-Alarm device.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 74530
Build 71413: arc lint + arc unit

Event Timeline

guest-seuros requested review of this revision.Sun, Jul 5, 8:45 PM
guest-seuros created this revision.
Harbormaster completed remote builds in B74530: Diff 181321.Sun, Jul 5, 8:45 PM
adrian added a project: drivers.Sun, Jul 5, 8:52 PM
adrian added a reviewer: drivers.
adrian added a subscriber: drivers.
guest-seuros mentioned this in D54954: atrtc: Prevent duplicate device attachment.Sun, Jul 5, 8:57 PM
ngie added a subscriber: ngie.Thu, Jul 9, 10:36 PM
ngie added inline comments.
sys/dev/acpica/acpi.c
2570–2575

Could you please add references to the ACPI handles in the comment above? Thanks!

ngie added subscribers: jhb, jkim.Thu, Jul 9, 10:37 PM
guest-seuros added inline comments.Thu, Jul 9, 10:54 PM
sys/dev/acpica/acpi.c
2570–2575

Do you mean this page ?
https://uefi.org/specs/ACPI/6.5_A/05_ACPI_Software_Programming_Model.html

I copied it from the pdf

ngie accepted this revision.Thu, Jul 9, 11:16 PM
ngie added inline comments.
sys/dev/acpica/acpi.c
2557–2575

Maybe something like this? The PNP0C0F description seems a bit wordy in my suggestion TBH, but maybe something like that to communicate that the state of things with absolute clarity?
Alternatively, if you just create a map of the devices--either using constants or using the handles mentioned in the comment--then link to the actual spec, that would help the reader to understand what the code does (and maybe add more driver quirks as needed in the future).

This revision is now accepted and ready to land.Thu, Jul 9, 11:16 PM
ngie resigned from this revision.Thu, Jul 9, 11:16 PM

Ugh. Didn't mean to "accept" the revision yet - I'm sorry :(.

This revision now requires review to proceed.Thu, Jul 9, 11:16 PM
ngie removed a reviewer: ngie.Thu, Jul 9, 11:17 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
42 lines

Diff 181321

View Options

sys/dev/acpica/acpi.c

Loading...