Differential D57370

bindat(2)/connectat(2): allow implicit EMPTYPATH for unix domain sockets
ClosedPublic
Actions

Authored by kib on Sat, May 30, 10:15 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jun 8, 6:32 PM

	Unknown Object (File)
	Mon, Jun 8, 2:13 AM

	Unknown Object (File)
	Mon, Jun 8, 2:07 AM

	Unknown Object (File)
	Sun, Jun 7, 7:43 PM

	Unknown Object (File)
	Sun, Jun 7, 6:36 PM

	Unknown Object (File)
	Sun, Jun 7, 2:47 AM

	Unknown Object (File)
	Fri, Jun 5, 8:03 PM

	Unknown Object (File)
	Sun, May 31, 11:25 AM

Subscribers

Details

Reviewers

bapt
markj
glebius

Commits

rG5d36fcc53d3d: open.2: document O_PATH behavior for bindat/connectat
rG12c590a9abd7: bindat(2)/connectat(2): allow implicit EMPTYPATH for unix domain sockets

Summary

path specification.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Sat, May 30, 10:15 PM

Herald added subscribers: olce, imp. · View Herald TranscriptSat, May 30, 10:15 PM

kib requested review of this revision.Sat, May 30, 10:15 PM

kib mentioned this in D56835: rcd(8): new service manager daemon.Sat, May 30, 10:20 PM

Document it

Herald added a subscriber: ziaee. · View Herald TranscriptTue, Jun 2, 1:48 PM

markj added inline comments.Tue, Jun 2, 2:42 PM

sys/kern/uipc_usrreq.c
617	As I understand it, bind() must create a new socket, as we use VOP_CREATE below. But then, how can we already have an fd for it?

kib added inline comments.Tue, Jun 2, 3:14 PM

sys/kern/uipc_usrreq.c
617	It must create the vnode if not existing, but also it must check for the existence of the vnode, the EADDINUSE error when vp != NULL. As is, I think it is useful if only for completeness.

markj accepted this revision.Tue, Jun 2, 3:31 PM

This revision is now accepted and ready to land.Tue, Jun 2, 3:31 PM

Closed by commit rG12c590a9abd7: bindat(2)/connectat(2): allow implicit EMPTYPATH for unix domain sockets (authored by kib). · Explain WhyTue, Jun 2, 4:38 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG12c590a9abd7: bindat(2)/connectat(2): allow implicit EMPTYPATH for unix domain sockets.

kib added a commit: rG5d36fcc53d3d: open.2: document O_PATH behavior for bindat/connectat.

Hello all,

Got a testunit error on devel/aws-c-io and there is a PR opened https://github.com/awslabs/aws-c-io/issues/803

Any clues around this?

Thanks

Revision Contents
Changeset List

Path

Size

sys/

kern/

7 lines

Diff 179096

sys/kern/uipc_usrreq.c

Loading...