Page MenuHomeFreeBSD
Differential D55561

acpi: Treat ACPI_IVAR_FLAGS as a global IVAR
AcceptedPublic
Actions

Authored by jhb on Fri, Feb 27, 3:52 PM.
Tags
None
Referenced Files
F146140198: D55561.diff
Sat, Feb 28, 4:04 AM
F146118971: D55561.id.diff
Fri, Feb 27, 11:40 PM
F146118107: D55561.diff
Fri, Feb 27, 11:30 PM
F146117552: D55561.id172868.diff
Fri, Feb 27, 11:23 PM
F146082162: D55561.id172868.diff
Fri, Feb 27, 4:00 PM
Subscribers
None

Details

Reviewers
imp
jkim
ngie
Summary

The ACPI bus uses the flags IVAR for any device with a _PRW method
including devices such as PCI bridges/devices that are not direct
children of acpi0.

Reported by: ngie
Fixes: 0bb867e9f565 ("acpi: Split ACPI IVARs into global and private sets")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71067
Build 67950: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Fri, Feb 27, 3:52 PM
jhb created this revision.
jhb added a child revision: D55562: acpi: Don't attach a "wake" sysctl node to devices without the ACPI flags IVAR.
Harbormaster completed remote builds in B71067: Diff 172868.Fri, Feb 27, 3:53 PM
ngie accepted this revision.EditedFri, Feb 27, 7:51 PM

LGTM. This also helped get my MBP13,1 back into a state where it no longer panicked running sysctl dev.pci. Does this complement D55562?

This revision is now accepted and ready to land.Fri, Feb 27, 7:51 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
4 lines

Diff 172868

View Options

sys/dev/acpica/acpivar.h

Loading...