Page MenuHomeFreeBSD
Differential D55561

acpi: Treat ACPI_IVAR_FLAGS as a global IVAR
ClosedPublic
Actions

Authored by jhb on Fri, Feb 27, 3:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 20, 5:20 AM
Unknown Object (File)
Fri, Mar 20, 3:35 AM
Unknown Object (File)
Fri, Mar 20, 3:35 AM
Unknown Object (File)
Fri, Mar 20, 3:09 AM
Unknown Object (File)
Wed, Mar 18, 5:28 PM
Unknown Object (File)
Sat, Mar 14, 11:37 PM
Unknown Object (File)
Sat, Mar 7, 3:17 AM
Unknown Object (File)
Thu, Mar 5, 11:18 AM
View All 18 Files
Subscribers
None

Details

Reviewers
imp
jkim
ngie
Commits
rG00ff89c1e0c8: acpi: Treat ACPI_IVAR_FLAGS as a global IVAR
Summary

The ACPI bus uses the flags IVAR for any device with a _PRW method
including devices such as PCI bridges/devices that are not direct
children of acpi0.

Reported by: ngie
Fixes: 0bb867e9f565 ("acpi: Split ACPI IVARs into global and private sets")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Fri, Feb 27, 3:52 PM
jhb created this revision.
jhb added a child revision: D55562: acpi: Don't attach a "wake" sysctl node to devices without the ACPI flags IVAR.
Harbormaster completed remote builds in B71067: Diff 172868.Fri, Feb 27, 3:53 PM
ngie accepted this revision.EditedFri, Feb 27, 7:51 PM

LGTM. This also helped get my MBP13,1 back into a state where it no longer panicked running sysctl dev.pci. Does this complement D55562?

This revision is now accepted and ready to land.Fri, Feb 27, 7:51 PM
Closed by commit rG00ff89c1e0c8: acpi: Treat ACPI_IVAR_FLAGS as a global IVAR (authored by jhb). · Explain WhyWed, Mar 4, 8:20 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG00ff89c1e0c8: acpi: Treat ACPI_IVAR_FLAGS as a global IVAR.

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
4 lines

Diff 173148

View Options

sys/dev/acpica/acpivar.h

Loading...