Page MenuHomeFreeBSD
Differential D54947

arm64: Add MOPS implementations of copyin/copyout
ClosedPublic
Actions

Authored by sarah.walker2_arm.com on Thu, Jan 29, 6:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 9, 12:11 AM
Unknown Object (File)
Wed, Feb 4, 9:39 AM
Unknown Object (File)
Wed, Feb 4, 2:20 AM
Unknown Object (File)
Tue, Feb 3, 10:55 PM
Unknown Object (File)
Tue, Feb 3, 5:25 AM
Unknown Object (File)
Mon, Feb 2, 8:44 PM
Unknown Object (File)
Sat, Jan 31, 3:45 AM
Unknown Object (File)
Fri, Jan 30, 2:45 PM
View All 13 Files
Subscribers
emaste
imp

Details

Reviewers
andrew
manu
Commits
rG1224347817c4: arm64: Add MOPS implementations of copyin/copyout
Summary

Reimplement copyin() & copyout() as ifuncs.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sarah.walker2_arm.com created this revision.Thu, Jan 29, 6:25 PM
Herald added a reviewer: andrew. · View Herald TranscriptThu, Jan 29, 6:25 PM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
sarah.walker2_arm.com requested review of this revision.Thu, Jan 29, 6:25 PM
sarah.walker2_arm.com added a parent revision: D54946: arm64: Add MOPS implementation of pagezero().
Harbormaster completed remote builds in B70214: Diff 170737.Thu, Jan 29, 6:26 PM
andrew added inline comments.Fri, Jan 30, 11:18 AM
sys/arm64/arm64/copyinout.S
90

You can use cpyf*rt and cpyf*wt directly to implement copyin & copyout.

As they execute the load/store as unprivileged operations you will need to set the fault handler, but don't need to enable user access.

sarah.walker2_arm.com updated this revision to Diff 170773.Fri, Jan 30, 12:27 PM

Address review comments.

Harbormaster completed remote builds in B70231: Diff 170773.Fri, Jan 30, 12:27 PM
andrew accepted this revision.Fri, Jan 30, 1:23 PM
This revision is now accepted and ready to land.Fri, Jan 30, 1:23 PM
sarah.walker2_arm.com updated this revision to Diff 170974.Mon, Feb 2, 10:01 AM

Address review comments.

This revision now requires review to proceed.Mon, Feb 2, 10:01 AM
Harbormaster completed remote builds in B70340: Diff 170974.Mon, Feb 2, 10:01 AM
andrew accepted this revision.Tue, Feb 3, 1:49 PM
This revision is now accepted and ready to land.Tue, Feb 3, 1:49 PM
sarah.walker2_arm.com updated this revision to Diff 171510.Mon, Feb 9, 11:52 AM

Remove mops_supported.

This revision now requires review to proceed.Mon, Feb 9, 11:52 AM
Harbormaster completed remote builds in B70544: Diff 171510.Mon, Feb 9, 11:52 AM
andrew accepted this revision.Mon, Feb 9, 5:31 PM
This revision is now accepted and ready to land.Mon, Feb 9, 5:31 PM
Closed by commit rG1224347817c4: arm64: Add MOPS implementations of copyin/copyout (authored by sarah.walker2_arm.com, committed by andrew). · Explain WhyTue, Feb 10, 3:43 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG1224347817c4: arm64: Add MOPS implementations of copyin/copyout.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
58 lines
50 lines
conf/
1 line

Diff 171675

View Options

sys/arm64/arm64/copyinout.S

Loading...
View Options

sys/arm64/arm64/copyinout_ifunc.c

Loading...
View Options

sys/conf/files.arm64

Loading...