if_gre: Add netlink support with tests

[pouria]

Summary

Add netlink support to if_gre

Test Plan

I also wrote tests for gre, since it doesn't have it before.

# kyua test -k /usr/tests/sys/netlink/Kyuafile test_rtnl_gre:test_rtnl_gre
test_rtnl_gre:test_rtnl_gre  ->  passed  [0.002s]
Results file id is usr_tests_sys_netlink.20260101-180800-774463
Results saved to /root/.kyua/store/results.usr_tests_sys_netlink.20260101-180800-774463.db
1/1 passed (0 failed)

[pouria]

kind reminder
@glebius

[zlei]

There're three tasks in this change,

1. Migrate to new if_clone KPI
2. Refactor some ioctls, say GRESKEY
3. Add netlink support

The first two are simple and easy to review, I expect them can be landed quickly. I'd support you to split the change.

[pouria]

In D54443#1257878, @zlei wrote:

There're three tasks in this change,

1. Migrate to new if_clone KPI
2. Refactor some ioctls, say GRESKEY
3. Add netlink support

The first two are simple and easy to review, I expect them can be landed quickly. I'd support you to split the change.

I understand your perspective, however, migrating directly to the new if_clone_addreq_v2 without netlink support is not possible.
I could migrate to if_clone_addreq without netlink support first, but then transition to v2 to support netlink would ultimately be redundant.
The same reasoning applies to the GRESKEY ioctl.
Refactoring that ioctl is intended to reuse those configuration functions through netlink.
Therefore, without netlink support, refactoring the ioctl interface is pointless.

[glebius]

sys/netlink/route/interface.h

252

Maybe IFLA_TUNNEL_GRE_UDP?

tests/sys/netlink/test_rtnl_gre.c

2

Please add BSD license and you authorship.

[pouria]

• Add types in if_gre.h to fix world build
• Add copyright to test_rtnl_gre.c
• Rebase to main and fix cleanup in test_rtnl_gre.

@glebius done.

[glebius]

Approved, but please address comment in the module event switch statement.

sys/net/if_gre.c

1146

See note about /* FALLTHROUGH */ in style(9). This actually is not only about style. Some linters may complain on this function unless this special comment is added. Adding break; instead will also work. So add either of them, depending on how would you expect gremodevent() change in the future. IMHO, break; is more likely to stay here in future.