Page MenuHomeFreeBSD

syscalls: Old setgroups(2)/getgroups(2): Remove superfluous STD type
ClosedPublic

Authored by olce on Sep 12 2025, 3:27 PM.
Tags
None
Referenced Files
F135603826: D52499.diff
Tue, Nov 11, 5:42 AM
Unknown Object (File)
Mon, Nov 10, 3:55 AM
Unknown Object (File)
Sat, Nov 1, 8:33 PM
Unknown Object (File)
Fri, Oct 24, 8:36 PM
Unknown Object (File)
Thu, Oct 23, 6:08 AM
Unknown Object (File)
Tue, Oct 21, 9:28 PM
Unknown Object (File)
Mon, Oct 20, 12:34 AM
Unknown Object (File)
Tue, Oct 14, 6:00 AM
Subscribers

Details

Summary

An examination of the scripts under 'sys/tools/syscalls' indicates that
keeping STD as a type in the presence of COMPATxx does not make any
difference, and regenerating system call files with STD removed does
indeed not show any difference. Moreover, this practice is inconsistent
with the rest of the file.

Thus, remove the superfluous STD type for the two above-mentioned system
calls. While here, re-order the remaining types for getgroups() to be
consistent with other such occurences (COMPATxx before CAPENABLED).

MFC after: 3 days
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Sep 12 2025, 3:27 PM
This revision is now accepted and ready to land.Sep 12 2025, 3:32 PM

Whoops, good shout.

Glad you reviewed that, because I was wondering if this was deliberate or not (maybe you were cooking some other changes related to that).