Page MenuHomeFreeBSD

OptionalObsoleteFiles.inc: add some now-optional rc.d scripts
ClosedPublic

Authored by ivy on May 28 2025, 12:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 17, 2:03 PM
Unknown Object (File)
Aug 30 2025, 9:50 AM
Unknown Object (File)
Aug 30 2025, 7:21 AM
Unknown Object (File)
Aug 14 2025, 4:32 PM
Unknown Object (File)
Aug 3 2025, 10:23 PM
Unknown Object (File)
Aug 3 2025, 5:14 AM
Unknown Object (File)
Jul 24 2025, 7:41 AM
Unknown Object (File)
Jul 10 2025, 2:13 AM
Subscribers
None

Details

Summary

After f91d251b399a, some rc.d scripts are gated behind the src.conf knob
for the services they start. Add them to OptionalObsoleteFiles.inc so
they are properly removed when the knob is disabled.

Fixes: f91d251b399a ("rc.d: move some rc scripts to their packages")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivy requested review of this revision.May 28 2025, 12:36 AM
ivy created this revision.

i've checked all of these and there do not appear to be any more instances of the problem in D50557, i.e. everything that depends on one of these scripts also depends on something else as well. it wouldn't hurt for someone else to check that again in case i missed something.

Generally seem fine to me, just a note about ctld.

tools/build/mk/OptionalObsoleteFiles.inc
2676

Humm, is the rc.d script conditional on MK_ISCSI? Given the last review about moving ctld into a ctl package I'm kind of surprised the rc.d script is conditional on this knob.

tools/build/mk/OptionalObsoleteFiles.inc
2676

Ah, so it is, but I think the correct fix is to make ctld always installed in rc.d/Makefile, that is MK_ISCSI should only restrict the iscsi package, not the ctl package.

remove ctld, since after D50625 it's no longer optional

This revision is now accepted and ready to land.Jun 1 2025, 2:52 AM