Page MenuHomeFreeBSD
Differential D50296

mail: Add test cases for SIGHUP.
ClosedPublic
Actions

Authored by des on May 11 2025, 1:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 9, 7:57 PM
Unknown Object (File)
Sun, Jun 8, 8:06 AM
Unknown Object (File)
Sun, Jun 1, 4:03 AM
Unknown Object (File)
Sat, May 31, 5:15 PM
Unknown Object (File)
Thu, May 29, 11:08 AM
Unknown Object (File)
Thu, May 29, 6:04 AM
Unknown Object (File)
Fri, May 16, 10:39 PM
Unknown Object (File)
Thu, May 15, 6:38 PM
View All 17 Files
Subscribers
imp
kevans

Details

Reviewers
kevans
Group Reviewers
Klara
Commits
rG5f636d1e9e2e: mail: Add test cases for SIGHUP.
rGa6bac0a9efa1: mail: Add test cases for SIGHUP.
Summary

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.May 11 2025, 1:39 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 11 2025, 1:39 PM
des requested review of this revision.May 11 2025, 1:39 PM
des added a parent revision: D50251: mail: exit with the correct exit status on SIGHUP.May 11 2025, 1:40 PM
Harbormaster completed remote builds in B64081: Diff 155284.May 11 2025, 1:40 PM
kevans mentioned this in D50251: mail: exit with the correct exit status on SIGHUP.Tue, May 13, 5:45 PM
kevans added a subscriber: kevans.Tue, May 13, 6:21 PM
kevans added inline comments.
usr.bin/mail/tests/mailx_signal_test.c
133

I wonder if we should reduce duplication by effectively reverting this and instead making it conditional on interactive && signo != SIGHUP, then pulling both of the dead.letter checks out to the end of mailx_signal_test contingent on interactive only.

des marked an inline comment as done.Wed, May 14, 6:14 PM
des updated this revision to Diff 155461.Wed, May 14, 6:15 PM

as suggested

Harbormaster completed remote builds in B64181: Diff 155461.Wed, May 14, 6:15 PM
kevans accepted this revision.Wed, May 14, 6:19 PM
This revision is now accepted and ready to land.Wed, May 14, 6:19 PM
Closed by commit rGa6bac0a9efa1: mail: Add test cases for SIGHUP. (authored by des). · Explain WhyWed, May 14, 7:32 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGa6bac0a9efa1: mail: Add test cases for SIGHUP..
des added a commit: rG5f636d1e9e2e: mail: Add test cases for SIGHUP..Wed, May 21, 5:49 PM

Revision Contents
Changeset List

PathSize
3 lines
usr.bin/
mail/
tests/
2 lines
mailx_signal_test.c
mail_sigint_test.c
58 lines

Diff 155467

View Options

ObsoleteFiles.inc

Loading...
View Options

usr.bin/mail/tests/Makefile

Loading...
View Options

usr.bin/mail/tests/mail_sigint_test.c

Loading...
View Options

usr.bin/mail/tests/mailx_signal_test.c

Loading...