Paths

Table of Contentst

Differential D50296

mail: Add test cases for SIGHUP.
ClosedPublic
Actions

Authored by des on May 11 2025, 1:39 PM.

Tags

None

Referenced Files

	F139619456: D50296.diff
	Sun, Dec 14, 5:51 AM

	Unknown Object (File)
	Thu, Dec 11, 9:06 AM

	Unknown Object (File)
	Tue, Dec 2, 5:17 AM

	Unknown Object (File)
	Mon, Dec 1, 5:01 AM

	Unknown Object (File)
	Thu, Nov 27, 10:44 AM

	Unknown Object (File)
	Thu, Nov 27, 9:21 AM

	Unknown Object (File)
	Mon, Nov 17, 12:06 PM

	Unknown Object (File)
	Nov 11 2025, 7:34 AM

View All 68 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG5f636d1e9e2e: mail: Add test cases for SIGHUP.
rGa6bac0a9efa1: mail: Add test cases for SIGHUP.

Summary

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64181
Build 61065: arc lint + arc unit

Event Timeline

des created this revision.May 11 2025, 1:39 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 11 2025, 1:39 PM

des requested review of this revision.May 11 2025, 1:39 PM

des added a parent revision: D50251: mail: exit with the correct exit status on SIGHUP.May 11 2025, 1:40 PM

Harbormaster completed remote builds in B64081: Diff 155284.May 11 2025, 1:40 PM

kevans mentioned this in D50251: mail: exit with the correct exit status on SIGHUP.May 13 2025, 5:45 PM

kevans added a subscriber: kevans.May 13 2025, 6:21 PM

kevans added inline comments.

usr.bin/mail/tests/mailx_signal_test.c
133	I wonder if we should reduce duplication by effectively reverting this and instead making it conditional on `interactive && signo != SIGHUP`, then pulling both of the dead.letter checks out to the end of `mailx_signal_test` contingent on `interactive` only.

des marked an inline comment as done.May 14 2025, 6:14 PM

as suggested

Harbormaster completed remote builds in B64181: Diff 155461.May 14 2025, 6:15 PM

kevans accepted this revision.May 14 2025, 6:19 PM

This revision is now accepted and ready to land.May 14 2025, 6:19 PM

Closed by commit rGa6bac0a9efa1: mail: Add test cases for SIGHUP. (authored by des). · Explain WhyMay 14 2025, 7:32 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGa6bac0a9efa1: mail: Add test cases for SIGHUP..

des added a commit: rG5f636d1e9e2e: mail: Add test cases for SIGHUP..May 21 2025, 5:49 PM

Revision Contents
Changeset List

Path

Size

ObsoleteFiles.inc

3 lines

usr.bin/

mail/

5 lines

tests/

2 lines

mail_sigint_test.c

	mailx_signal_test.c
	mail_sigint_test.c

58 lines

Diff 155461

ObsoleteFiles.inc

Loading...

usr.bin/mail/collect.c

Loading...

usr.bin/mail/tests/Makefile

Loading...

usr.bin/mail/tests/mail_sigint_test.c

Loading...

usr.bin/mail/tests/mailx_signal_test.c

Loading...