Page MenuHomeFreeBSD
Differential D48094

rtwn: only set INIRATE if we're not doing firmware rate control.
ClosedPublic
Actions

Authored by adrian on Dec 15 2024, 9:09 PM.
Tags
Referenced Files
F156256660: D48094.id148617.diff
Mon, May 11, 10:57 PM
F156255969: D48094.diff
Mon, May 11, 10:50 PM
F156203175: D48094.id.diff
Mon, May 11, 3:07 PM
Unknown Object (File)
Wed, Apr 29, 1:30 PM
Unknown Object (File)
Wed, Apr 29, 1:24 PM
Unknown Object (File)
Tue, Apr 28, 4:59 AM
Unknown Object (File)
Mon, Apr 27, 11:34 PM
Unknown Object (File)
Mon, Apr 27, 1:26 PM
View All 97 Files
Subscribers
bz
imp

Details

Reviewers
bz
Group Reviewers
wireless
Commits
rG307f9c351588: rtwn: only set INIRATE if we're not doing firmware rate control.
Summary

This register (array) controls the initial rate to use for each
MACID. There's no need to set it if firmware rate control is enabled -
it'll actually be under firmware control (and we can read it back to
see what choices the firmware is making.)

Locally tested:

  • RTL8188EU, STA
  • RTL8192CU, STA
  • RTL8192EU, STA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 61182
Build 58066: arc lint + arc unit

Event Timeline

adrian created this revision.Dec 15 2024, 9:09 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 15 2024, 9:09 PM
adrian requested review of this revision.Dec 15 2024, 9:09 PM
Harbormaster completed remote builds in B61182: Diff 147993.Dec 15 2024, 9:09 PM
adrian added a parent revision: D48092: rtwn: remove SEQ_SEL, replace with a QOS bit.Dec 15 2024, 9:10 PM
adrian added a reviewer: wireless.
adrian added a project: wireless.
adrian added a child revision: D48096: net80211: add TX rate control completion fields for HT, VHT, channel info.Dec 15 2024, 10:26 PM
bz accepted this revision as: bz.Dec 31 2024, 6:20 AM
bz added a subscriber: bz.

I cannot check the statement but if your comment is correct this seems fine.

This revision is now accepted and ready to land.Dec 31 2024, 6:20 AM
Closed by commit rG307f9c351588: rtwn: only set INIRATE if we're not doing firmware rate control. (authored by adrian). · Explain WhyDec 31 2024, 7:13 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG307f9c351588: rtwn: only set INIRATE if we're not doing firmware rate control..
adrian added a child revision: D48097: rtwn: enable VHT if it's configured in the device.Jan 9 2025, 5:06 PM
adrian removed a child revision: D48096: net80211: add TX rate control completion fields for HT, VHT, channel info.

Revision Contents
Changeset List

PathSize
sys/
dev/
rtwn/
rtl8192c/
7 lines

Diff 147993

View Options

sys/dev/rtwn/rtl8192c/r92c_fw.c

Loading...