Page MenuHomeFreeBSD
Differential D47766

rtwn: use ieee80211_ht_get_node_ampdu_density(), fix programming MAX_AGG
ClosedPublic
Actions

Authored by adrian on Nov 26 2024, 5:06 PM.
Tags
Referenced Files
F106165965: D47766.id146991.diff
Thu, Dec 26, 11:38 AM
F106161364: D47766.id146992.diff
Thu, Dec 26, 9:50 AM
F106155638: D47766.id147520.diff
Thu, Dec 26, 7:37 AM
F106147929: D47766.id147341.diff
Thu, Dec 26, 4:42 AM
Unknown Object (File)
Wed, Dec 25, 9:47 AM
Unknown Object (File)
Sat, Dec 21, 11:30 AM
Unknown Object (File)
Fri, Dec 20, 9:05 PM
Unknown Object (File)
Fri, Dec 20, 3:07 PM
View All 10 Files
Subscribers
bz
imp

Details

Reviewers
bz
Group Reviewers
wireless
Commits
rG77e64f45c478: rtwn: use ieee80211_ht_get_node_ampdu_density(), fix programming MAX_AGG
Summary
  • use ieee80211_ht_get_node_ampdu_density() now instead of the vap->iv_ampdu_density, so the correct density is used in AP/IBSS/mesh modes.
  • MAX_AGG controls how many frames are to be sent in an A-MPDU. It maps to ((MAX_AGG * 2) + 1) == npackets. 0x1f (31) means 64 packets. So, instead of hard-coding 0x1f, use the negotiated block-ack window size.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 60796
Build 57680: arc lint + arc unit

Event Timeline

adrian created this revision.Nov 26 2024, 5:06 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 26 2024, 5:06 PM
adrian requested review of this revision.Nov 26 2024, 5:06 PM
Harbormaster completed remote builds in B60795: Diff 146991.Nov 26 2024, 5:06 PM
adrian updated this revision to Diff 146992.Nov 26 2024, 5:07 PM

add url

Harbormaster completed remote builds in B60796: Diff 146992.Nov 26 2024, 5:07 PM
adrian added a parent revision: D47755: iwn: use ieee80211_ht_check_tx_ht().Nov 26 2024, 5:07 PM
adrian added a reviewer: wireless.
adrian added a project: wireless.
adrian added a child revision: D47774: rtwn: fix rtl8812/rtl8821 vht definitions, add VHT calibration/rate control.Wed, Nov 27, 12:08 AM
bz requested changes to this revision.Thu, Nov 28, 1:00 AM
bz added a subscriber: bz.
bz added inline comments.
sys/dev/rtwn/rtl8192c/r92c_tx.c
270

If you do the assignment outside the declaration you don't have to wrap; also you can do it when you need it.
(same in the other file)

This revision now requires changes to proceed.Thu, Nov 28, 1:00 AM
adrian updated this revision to Diff 147341.Mon, Dec 2, 6:51 AM

pull window calc code into their own routines

Harbormaster completed remote builds in B60909: Diff 147341.Mon, Dec 2, 6:51 AM
adrian added a comment.Mon, Dec 2, 7:17 AM

ok, please re-review!

adrian marked an inline comment as done.Mon, Dec 2, 7:18 AM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Dec 5, 7:31 AM
Closed by commit rG77e64f45c478: rtwn: use ieee80211_ht_get_node_ampdu_density(), fix programming MAX_AGG (authored by adrian). · Explain Why
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG77e64f45c478: rtwn: use ieee80211_ht_get_node_ampdu_density(), fix programming MAX_AGG.

Revision Contents
Changeset List

PathSize
sys/
dev/
rtwn/
rtl8192c/
18 lines
rtl8812a/
18 lines

Diff 146992

View Options

sys/dev/rtwn/rtl8192c/r92c_tx.c

Loading...
View Options

sys/dev/rtwn/rtl8812a/r12a_tx.c

Loading...