Page MenuHomeFreeBSD
Differential D46578

pf tests: test the new received-on feature
ClosedPublic
Actions

Authored by kp on Sep 7 2024, 9:34 AM.
Tags
None
Referenced Files
F106170839: D46578.diff
Thu, Dec 26, 1:32 PM
Unknown Object (File)
Sat, Dec 7, 9:04 AM
Unknown Object (File)
Sat, Dec 7, 9:04 AM
Unknown Object (File)
Sat, Dec 7, 9:04 AM
Unknown Object (File)
Sat, Dec 7, 9:04 AM
Unknown Object (File)
Thu, Dec 5, 10:12 PM
Unknown Object (File)
Tue, Dec 3, 8:28 PM
Unknown Object (File)
Mon, Dec 2, 8:29 PM
View All 43 Files
Subscribers
farrokhi
glebius
imp
melifaro
vegeta_tuxpowered.net
zlei

Details

Reviewers
zlei
Group Reviewers
network
pfsense
Commits
rG661d0031bbc6: pf tests: test the new received-on feature
Summary

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59366
Build 56253: arc lint + arc unit

Event Timeline

kp created this revision.Sep 7 2024, 9:34 AM
Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptSep 7 2024, 9:34 AM
Harbormaster completed remote builds in B59366: Diff 143074.Sep 7 2024, 9:34 AM
kp requested review of this revision.Sep 7 2024, 9:34 AM
kp added a parent revision: D46577: pf: allow filtering on the receive interface.
kp added a child revision: D46579: pf.conf.5: document received-on.
zlei accepted this revision as: zlei.Sep 14 2024, 7:41 AM
zlei added a subscriber: zlei.

The test code looks good to me.

sbin/pfctl/tests/files/pf1022.ok
1

What purpose do those two files pf1022.in and pf1022.ok serve ?

This revision is now accepted and ready to land.Sep 14 2024, 7:41 AM
zlei added a comment.Sep 14 2024, 7:44 AM

The document says received-on can work on interface group. Shall we add additional tests for that case ?

kp added a comment.Sep 16 2024, 9:46 AM
In D46578#1063694, @zlei wrote:

The document says received-on can work on interface group. Shall we add additional tests for that case ?

That is an excellent idea. I'll add a test case.
It should just work, because we use pf_match_rcvif() to do the matching, but tests are good anyway.

sbin/pfctl/tests/files/pf1022.ok
1

They're part of the pfctl parser tests. We feed the .in file to it, and check that it produces the expected output. Basically making sure it can parse things the way we expect them to be parsed.

kp updated this revision to Diff 143380.Sep 16 2024, 10:07 AM

Also test received-on <group>

This revision now requires review to proceed.Sep 16 2024, 10:07 AM
Harbormaster completed remote builds in B59503: Diff 143380.Sep 16 2024, 10:07 AM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2024, 1:06 PM
Closed by commit rG661d0031bbc6: pf tests: test the new received-on feature (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG661d0031bbc6: pf tests: test the new received-on feature.

Revision Contents
Changeset List

PathSize
sbin/
pfctl/
tests/
files/
1 line
1 line
1 line
tests/
sys/
netpfil/
pf/
65 lines

Diff 143074

View Options

sbin/pfctl/tests/files/pf1022.in

Loading...
View Options

sbin/pfctl/tests/files/pf1022.ok

Loading...
View Options

sbin/pfctl/tests/pfctl_test_list.inc

Loading...
View Options

tests/sys/netpfil/pf/pass_block.sh

Loading...