Differential D38005

stand: create common set_currdev
ClosedPublic
Actions

Authored by imp on Jan 10 2023, 12:18 AM.

Tags

None

Referenced Files

	F171217460: D38005.diff
	Wed, Sep 9, 2:39 PM

	Unknown Object (File)
	Sat, Sep 5, 5:22 AM

	Unknown Object (File)
	Thu, Sep 3, 9:52 AM

	Unknown Object (File)
	Thu, Sep 3, 8:53 AM

	Unknown Object (File)
	Thu, Sep 3, 6:00 AM

	Unknown Object (File)
	Wed, Sep 2, 11:06 PM

	Unknown Object (File)
	Wed, Sep 2, 2:33 PM

	Unknown Object (File)
	Tue, Sep 1, 8:54 AM

Subscribers

Details

Reviewers

kevans
manu

Group Reviewers

Commits

rG7956ceec924a: stand: create common set_currdev
rGad70f2e22ef2: stand: create common set_currdev

Summary

Pull together the nearly identical copies of set_currdev in i386,
userboot and efi. Other boot loaders have variances that might be fine
to use the common routine, or not. Since they are harder to test for me,
and ofw and uboot do handle these setting differently, leave them be for
now.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jan 10 2023, 12:18 AM

Herald added a reviewer: manu. · View Herald TranscriptJan 10 2023, 12:18 AM

Herald added a reviewer: bhyve. · View Herald Transcript

Herald added subscribers: dab, bcran, rgrimes. · View Herald Transcript

imp requested review of this revision.Jan 10 2023, 12:18 AM

Harbormaster completed remote builds in B49033: Diff 114914.Jan 10 2023, 12:18 AM

imp added a parent revision: D38004: stand: Move dev_cleanup into libsa.Jan 10 2023, 12:18 AM

imp added a child revision: D38006: stand/zfs: Fix memory leaking on error cases.

kevans accepted this revision.Jan 11 2023, 12:17 AM

This revision is now accepted and ready to land.Jan 11 2023, 12:17 AM

Closed by commit rGad70f2e22ef2: stand: create common set_currdev (authored by imp). · Explain WhyJan 11 2023, 10:17 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGad70f2e22ef2: stand: create common set_currdev.

imp added a commit: rG7956ceec924a: stand: create common set_currdev.Jan 24 2023, 10:21 PM

Revision Contents
Changeset List

Path

Size

stand/

common/

1 line

17 lines

efi/

loader/

14 lines

i386/

loader/

5 lines

userboot/

userboot/

10 lines

Diff 114971

stand/common/bootstrap.h

Loading...

stand/common/misc.c

Loading...

stand/efi/loader/main.c

Loading...

stand/i386/loader/main.c

Loading...

stand/userboot/userboot/main.c

Loading...