Page MenuHomeFreeBSD

kboot: Add ZFS support to hostdisk
ClosedPublic

Authored by imp on Jan 10 2023, 12:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 16, 3:12 PM
Unknown Object (File)
Fri, Jun 14, 3:23 AM
Unknown Object (File)
Fri, Jun 14, 3:23 AM
Unknown Object (File)
Fri, Jun 14, 3:23 AM
Unknown Object (File)
Fri, Jun 14, 3:23 AM
Unknown Object (File)
Fri, Jun 14, 2:57 AM
Unknown Object (File)
May 9 2024, 5:23 AM
Unknown Object (File)
May 3 2024, 8:24 AM
Subscribers

Details

Summary

Add helper function to walk through the disk drives we've found to look
for zpools. main.c will still need to call this because the loader
hasn't implemented a good way to 'taste' drives for zpools and/or GELI
partitions (mostly because there's no generic list of candidate
devices).

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jan 10 2023, 12:19 AM
stand/kboot/hostdisk.c
477

... or at least somewhere in common since it needs sanity_check_currdev and It's not clear to me that belongs in libsa instead of common, which means probe_zfs_currdev shouldn't be in libsa since it would then depend on something defined in common...

508

I moved this here to make sure that we only setup this stuff if we're successful. It's not clear the error handling is quite right here though. But init_zfs_boot_options also has some error handling issues if it bails out in the middle: It will leave a number of env vars set improperly (imho).

This revision is now accepted and ready to land.Jan 12 2023, 5:35 AM
This revision was automatically updated to reflect the committed changes.