Page MenuHomeFreeBSD

rtsock: subscribe to ifnet eventhandlers instead of direct calls.
ClosedPublic

Authored by melifaro on Aug 9 2022, 9:08 PM.

Details

Summary

Stop treating rtsock as a "special" consumer and use already-provided
ifaddr arrival/departure notifications.

MFC after: 2 weeks

Test Plan
21:05 [0] m@devel0 route -n monitor

-> ifconfig vtnet0.2 create

got message of size 24 on Tue Aug  9 21:05:44 2022
RTM_IFANNOUNCE: interface arrival/departure: len 24, if# 3, what: arrival

got message of size 168 on Tue Aug  9 21:05:54 2022
RTM_IFINFO: iface status change: len 168, if# 3, link: up, flags:<BROADCAST,RUNNING,SIMPLEX,MULTICAST>

-> ifconfig vtnet0.2 destroy

got message of size 24 on Tue Aug  9 21:05:54 2022
RTM_IFANNOUNCE: interface arrival/departure: len 24, if# 3, what: departure

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

melifaro added a reviewer: network.
sys/net/rtsock.c
297

Just following our today conversation. Here we should either use EVENTHANDLER_DEFINE() or actually implement proper EVENTHANDLER_SYSINIT(). Did you check that EVENTHANDLER_DEFINE() will or will not work here?

This revision is now accepted and ready to land.Aug 11 2022, 2:37 PM