Page MenuHomeFreeBSD

vt/vga: ignore ACPI_FADT_NO_VGA unless running virtualized
ClosedPublic

Authored by royger on Feb 28 2022, 9:29 AM.

Details

Summary

There's too many broken hardware out there that wrongly has the
ACPI_FADT_NO_VGA bit set. Ignore it unless running as a virtualized
guest, as then the expectation would be that the hypervisor does
provide correct ACPI tables.

Sponsored by: Citrix Systems R&D
PR: 230172

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste added inline comments.
sys/dev/vt/hw/vga/vt_vga.c
1268

Some other cases in the tree seem to add (not actually necessary) parens

ignore = (vm_guest == VM_GUEST_NO);

to me this is a bit clearer.

This revision is now accepted and ready to land.Feb 28 2022, 4:06 PM

Also let's MFC this to include in 13.1

We should update vt.4 also

hw.vga.acpi_ignore_no_vga
        Set to 1 to force the usage of the VGA driver regardless of
        whether ACPI IAPC_BOOT_ARCH signals no VGA support.  Can be used
        to workaround firmware bugs in the ACPI tables.
This revision now requires review to proceed.Mar 17 2022, 11:54 AM

Please merge it to stable/12, too.

This revision is now accepted and ready to land.Mar 17 2022, 12:34 PM
0mp added a subscriber: 0mp.

The manual page change seems OK.

share/man/man4/vt.4
209

Please bump the Dd of the manual page when committing.