Page MenuHomeFreeBSD
Differential D34071

insmntque1(): remove useless arguments
ClosedPublic
Actions

Authored by kib on Jan 28 2022, 1:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 2:15 AM
Unknown Object (File)
Mar 16 2024, 4:50 PM
Unknown Object (File)
Mar 8 2024, 12:06 AM
Unknown Object (File)
Feb 12 2024, 2:19 PM
Unknown Object (File)
Feb 11 2024, 5:21 AM
Unknown Object (File)
Jan 2 2024, 1:50 PM
Unknown Object (File)
Dec 20 2023, 1:50 AM
Unknown Object (File)
Dec 19 2023, 3:10 PM
View All 35 Files
Subscribers
imp

Details

Reviewers
markj
mjg
jah
Commits
rG90be4091a76e: insmntque(9): update and correct man page
rG66c5fbca7719: insmntque1(): remove useless arguments
Summary

Also remove once-used functions to clean up after failed insmntque1(), which were destructor callbacks in previous life.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Jan 28 2022, 1:00 AM
Herald added a subscriber: imp. · View Herald TranscriptJan 28 2022, 1:00 AM
kib requested review of this revision.Jan 28 2022, 1:00 AM
markj accepted this revision.Jan 28 2022, 2:51 PM

There is an insmntque.9 man page which should be updated.

This revision is now accepted and ready to land.Jan 28 2022, 2:51 PM
kib updated this revision to Diff 102075.Jan 29 2022, 12:58 AM

Update insmntque(9), also fixing some other issues in the text.

This revision now requires review to proceed.Jan 29 2022, 12:58 AM
markj accepted this revision.Jan 31 2022, 2:23 PM
markj added inline comments.
share/man/man9/insmntque.9
74 ↗(On Diff #102075)
75 ↗(On Diff #102075)

I'd clarify a bit:

the operation vector
.Va v_op
and
.Va v_data
fields of the vnode are kept intact.

This revision is now accepted and ready to land.Jan 31 2022, 2:23 PM
kib marked 2 inline comments as done.Jan 31 2022, 2:50 PM
Closed by commit rG66c5fbca7719: insmntque1(): remove useless arguments (authored by kib). · Explain WhyJan 31 2022, 2:54 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG66c5fbca7719: insmntque1(): remove useless arguments.
kib added a commit: rG90be4091a76e: insmntque(9): update and correct man page.

Revision Contents
Changeset List

PathSize
sys/
fs/
devfs/
21 lines
fdescfs/
2 lines
nullfs/
2 lines
tmpfs/
25 lines
unionfs/
2 lines
kern/
38 lines
sys/
3 lines

Diff 102160

View Options

sys/fs/devfs/devfs_vnops.c

Loading...
View Options

sys/fs/fdescfs/fdesc_vnops.c

Loading...
View Options

sys/fs/nullfs/null_subr.c

Loading...
View Options

sys/fs/tmpfs/tmpfs_subr.c

Loading...
View Options

sys/fs/unionfs/union_subr.c

Loading...
View Options

sys/kern/vfs_subr.c

Loading...
View Options

sys/sys/vnode.h

Loading...