Page MenuHomeFreeBSD
Differential D32964

tcp: better congestion control defaults
ClosedPublic
Actions

Authored by imp on Nov 12 2021, 5:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 23, 6:43 PM
Unknown Object (File)
Thu, Apr 11, 1:28 PM
Unknown Object (File)
Jan 13 2024, 11:41 AM
Unknown Object (File)
Dec 20 2023, 5:51 AM
Unknown Object (File)
Dec 17 2023, 6:30 AM
Unknown Object (File)
Dec 12 2023, 7:49 AM
Unknown Object (File)
Nov 28 2023, 7:09 PM
Unknown Object (File)
Nov 24 2023, 9:55 AM
View All 27 Files
Subscribers
andrew
emaste
• hselasky
jhb
jhibbits
melifaro

Details

Reviewers
manu
• hselasky
jhb
glebius
tuexen
Group Reviewers
transport
Commits
rG7e3c9ec906c0: tcp: better congestion control defaults
Summary

Define CC_NEWRENO in all the appropriate DEFAULTS and std.* config
files. It's the default congestion control algorithm. Add code to cc.c
so that CC_DEFAULT is "newreno" if it's not overriden in the config
file.

Sponsored by: Netflix

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42756
Build 39644: arc lint + arc unit

Event Timeline

imp created this revision.Nov 12 2021, 5:08 PM
Herald added a reviewer: manu. · View Herald TranscriptNov 12 2021, 5:08 PM
Herald added a reviewer: transport. · View Herald Transcript
Herald added subscribers: melifaro, jhibbits, emaste, andrew. · View Herald Transcript
imp requested review of this revision.Nov 12 2021, 5:08 PM
Harbormaster completed remote builds in B42756: Diff 98427.Nov 12 2021, 5:08 PM
• hselasky accepted this revision.Nov 12 2021, 5:13 PM
• hselasky added a subscriber: • hselasky.

Looks good.

andrew added a comment.Nov 12 2021, 5:17 PM

It might pay to switch to options<space><tab>CC_NEWRENO while here to make its style consistent with the other options.

jhb accepted this revision.Nov 12 2021, 5:37 PM
jhb added a subscriber: jhb.

+1 to using the normal style (options<space><tab>)

manu accepted this revision.Nov 12 2021, 5:48 PM

Thanks, looks saner that way.
Same comment than Andrew and John though :)

glebius accepted this revision.Nov 12 2021, 6:36 PM
tuexen accepted this revision.Nov 12 2021, 6:38 PM
This revision is now accepted and ready to land.Nov 12 2021, 6:38 PM
Closed by commit rG7e3c9ec906c0: tcp: better congestion control defaults (authored by imp). · Explain WhyNov 12 2021, 7:19 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG7e3c9ec906c0: tcp: better congestion control defaults.
rscheff mentioned this in D36537: tcp: make cubic the default cc..Sep 12 2022, 2:11 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
conf/
3 lines
2 lines
2 lines
arm/
conf/
3 lines
arm64/
conf/
3 lines
i386/
conf/
3 lines
2 lines
2 lines
mips/
conf/
3 lines
netinet/
cc/
7 lines
powerpc/
conf/
3 lines
2 lines
riscv/
conf/
3 lines
2 lines

Diff 98427

View Options

sys/amd64/conf/DEFAULTS

Loading...
View Options

sys/amd64/conf/GENERIC

Loading...
View Options

sys/amd64/conf/MINIMAL

Loading...
View Options

sys/arm/conf/DEFAULTS

Loading...
View Options

sys/arm64/conf/DEFAULTS

Loading...
View Options

sys/i386/conf/DEFAULTS

Loading...
View Options

sys/i386/conf/GENERIC

Loading...
View Options

sys/i386/conf/MINIMAL

Loading...
View Options

sys/mips/conf/DEFAULTS

Loading...
View Options

sys/netinet/cc/cc.c

Loading...
View Options

sys/powerpc/conf/DEFAULTS

Loading...
View Options

sys/powerpc/conf/GENERIC

Loading...
View Options

sys/riscv/conf/DEFAULTS

Loading...
View Options

sys/riscv/conf/GENERIC

Loading...