Page MenuHomeFreeBSD
Differential D32446

LinuxKPI: Implement _ioremap_attr for riscv
ClosedPublic
Actions

Authored by jrtc27 on Oct 10 2021, 7:09 PM.
Tags
None
Referenced Files
F167462025: D32446.id96637.diff
Fri, Aug 21, 10:21 PM
F167460526: D32446.diff
Fri, Aug 21, 10:06 PM
Unknown Object (File)
Wed, Aug 12, 9:48 PM
Unknown Object (File)
Wed, Aug 12, 3:34 PM
Unknown Object (File)
Tue, Aug 11, 11:42 PM
Unknown Object (File)
Tue, Aug 11, 11:22 PM
Unknown Object (File)
Mon, Aug 10, 6:58 PM
Unknown Object (File)
Mon, Aug 10, 5:51 PM
View All Files
Subscribers
bz
emaste
imp
linuxkpi

Details

Reviewers
• hselasky
manu
bz
Commits
rGfeb3031f0ae8: LinuxKPI: Implement _ioremap_attr for riscv
rG60d962e04103: LinuxKPI: Implement _ioremap_attr for riscv
Summary

Now that riscv implements pmap_mapdev_attr we can enable the non-stub
implementation for riscv, which is needed for drm-kmod to not fail at
run time for drivers that need to map I/O regions.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrtc27 created this revision.Oct 10 2021, 7:09 PM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptOct 10 2021, 7:09 PM
jrtc27 requested review of this revision.Oct 10 2021, 7:09 PM
Harbormaster completed remote builds in B42057: Diff 96637.Oct 10 2021, 7:09 PM
jrtc27 added a parent revision: D32445: riscv: Implement pmap_mapdev_attr.Oct 10 2021, 7:10 PM
jrtc27 edited the summary of this revision. (Show Details)Oct 10 2021, 7:22 PM
• hselasky accepted this revision.Oct 11 2021, 9:23 AM
This revision is now accepted and ready to land.Oct 11 2021, 9:23 AM
bz accepted this revision.Oct 11 2021, 12:11 PM
bz added a subscriber: bz.

I guess we don't wrap lines anymore to looks good.

jrtc27 added a comment.Oct 12 2021, 2:07 PM
In D32446#731893, @bz wrote:

I guess we don't wrap lines anymore to looks good.

Yeah, already well over the limit so just left them alone...

Closed by commit rG60d962e04103: LinuxKPI: Implement _ioremap_attr for riscv (authored by jrtc27). · Explain WhyOct 17 2021, 2:38 PM
This revision was automatically updated to reflect the committed changes.
jrtc27 added a commit: rG60d962e04103: LinuxKPI: Implement _ioremap_attr for riscv.
imp added inline comments.Oct 17 2021, 3:44 PM
sys/compat/linuxkpi/common/include/linux/io.h
393

Sorry for the late comment, but can't we just remove this ifdef now? We have no linuxkpi support for arm and mips*, right?

jrtc27 added inline comments.Oct 17 2021, 3:45 PM
sys/compat/linuxkpi/common/include/linux/io.h
393

sys/modules enables the module unconditionally

jrtc27 added a commit: rGfeb3031f0ae8: LinuxKPI: Implement _ioremap_attr for riscv.Oct 24 2021, 6:54 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
2 lines
src/
4 lines

Diff 97002

View Options

sys/compat/linuxkpi/common/include/linux/io.h

Loading...
View Options

sys/compat/linuxkpi/common/src/linux_compat.c

Loading...