LinuxKPI: Implement _ioremap_attr for riscv
ClosedPublic
Actions

Authored by jrtc27 on Oct 10 2021, 7:09 PM.

Details

Reviewers

• hselasky
manu
bz

Commits

rGfeb3031f0ae8: LinuxKPI: Implement _ioremap_attr for riscv
rG60d962e04103: LinuxKPI: Implement _ioremap_attr for riscv

Summary

Now that riscv implements pmap_mapdev_attr we can enable the non-stub
implementation for riscv, which is needed for drm-kmod to not fail at
run time for drivers that need to map I/O regions.

MFC after: 1 week

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42057
Build 38945: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Oct 10 2021, 7:09 PM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptOct 10 2021, 7:09 PM

jrtc27 requested review of this revision.Oct 10 2021, 7:09 PM

Harbormaster completed remote builds in B42057: Diff 96637.Oct 10 2021, 7:09 PM

jrtc27 added a parent revision: D32445: riscv: Implement pmap_mapdev_attr.Oct 10 2021, 7:10 PM

jrtc27 edited the summary of this revision. (Show Details)Oct 10 2021, 7:22 PM

• hselasky accepted this revision.Oct 11 2021, 9:23 AM

This revision is now accepted and ready to land.Oct 11 2021, 9:23 AM

I guess we don't wrap lines anymore to looks good.

In D32446#731893, @bz wrote:

I guess we don't wrap lines anymore to looks good.

Yeah, already well over the limit so just left them alone...

Closed by commit rG60d962e04103: LinuxKPI: Implement _ioremap_attr for riscv (authored by jrtc27). · Explain WhyOct 17 2021, 2:38 PM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG60d962e04103: LinuxKPI: Implement _ioremap_attr for riscv.

imp added inline comments.Oct 17 2021, 3:44 PM

sys/compat/linuxkpi/common/include/linux/io.h
393	Sorry for the late comment, but can't we just remove this ifdef now? We have no linuxkpi support for arm and mips*, right?

jrtc27 added inline comments.Oct 17 2021, 3:45 PM

sys/compat/linuxkpi/common/include/linux/io.h
393	sys/modules enables the module unconditionally

jrtc27 added a commit: rGfeb3031f0ae8: LinuxKPI: Implement _ioremap_attr for riscv.Oct 24 2021, 6:54 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

io.h

2 lines

src/

linux_compat.c

4 lines

Diff 96637

View Options

sys/compat/linuxkpi/common/include/linux/io.h