Page MenuHomeFreeBSD
Differential D31248

umtx: Split umtx.h on two counterparts.
ClosedPublic
Actions

Authored by dchagin on Jul 20 2021, 7:21 PM.
Tags
None
Referenced Files
F166115830: D31248.id92530.diff
Tue, Aug 11, 8:40 PM
F166094456: D31248.id92530.diff
Tue, Aug 11, 4:35 PM
F166075595: D31248.id92925.diff
Tue, Aug 11, 1:30 PM
F166056137: D31248.id.diff
Tue, Aug 11, 9:53 AM
Unknown Object (File)
Mon, Aug 10, 7:02 PM
Unknown Object (File)
Sun, Aug 9, 3:33 PM
Unknown Object (File)
Sun, Aug 9, 9:35 AM
Unknown Object (File)
Sun, Aug 9, 9:30 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
markj
Commits
rGf51368016df4: umtx: Split umtx.h on two counterparts.
rGaf29f3995882: umtx: Split umtx.h on two counterparts.
Summary

To prevent umtx.h polluting by future changes split it on two headers:
umtx.h - ABI header for userspace;
umtxvar.h - the kernel staff.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dchagin created this revision.Jul 20 2021, 7:21 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 20 2021, 7:21 PM
dchagin requested review of this revision.Jul 20 2021, 7:21 PM
Harbormaster completed remote builds in B40571: Diff 92514.Jul 20 2021, 7:21 PM
dchagin added reviewers: kib, markj.Jul 20 2021, 7:24 PM
dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
dchagin mentioned this in D31234: umtx: Add bitset member to the struct umtx_q..Jul 20 2021, 7:27 PM
dchagin mentioned this in D31235: umtx: Add umtxq_requeue Linux emulation layer extension..
dchagin mentioned this in D31236: linux(4): Reimplement futexes using umtx..
dchagin mentioned this in D31237: umtx: Expose some of the pi umtx structures and API to the rest of the kernel..Jul 20 2021, 7:30 PM
dchagin mentioned this in D31238: umtx: Split do_unlock_pi on two counterparts..
dchagin mentioned this in D31240: linux(4): Implement pi futexes using umtx..Jul 20 2021, 7:34 PM
dchagin added a child revision: D31233: umtx: Expose some of the umtx structures and API to the rest of the kernel..Jul 20 2021, 9:40 PM
kib added inline comments.Jul 20 2021, 10:00 PM
sys/sys/umtxvar.h
36

Please do not do this. We prefer to not nest includes. Consumer should include sys/umtx.h, then sys/umtxvar.h.

90

While there, fix style. Indent should be +4 spaces for continuation lines.

dchagin updated this revision to Diff 92530.Jul 20 2021, 10:24 PM

done. thank you

Harbormaster completed remote builds in B40584: Diff 92530.Jul 20 2021, 10:25 PM
dchagin updated this revision to Diff 92531.Jul 20 2021, 10:27 PM

blank line after { added in the umtx_key_match

Harbormaster completed remote builds in B40585: Diff 92531.Jul 20 2021, 10:27 PM
kib accepted this revision.Jul 20 2021, 10:43 PM
This revision is now accepted and ready to land.Jul 20 2021, 10:43 PM
Closed by commit rGaf29f3995882: umtx: Split umtx.h on two counterparts. (authored by dchagin). · Explain WhyJul 29 2021, 9:46 AM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rGaf29f3995882: umtx: Split umtx.h on two counterparts..
dchagin added a commit: rGf51368016df4: umtx: Split umtx.h on two counterparts..Jun 17 2022, 7:38 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
cloudabi/
2 lines
linux/
2 lines
kern/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
1 line
2 lines
2 lines
sys/
73 lines
106 lines

Diff 92925

View Options

sys/compat/cloudabi/cloudabi_futex.c

Loading...
View Options

sys/compat/linux/linux_futex.c

Loading...
View Options

sys/kern/kern_exec.c

Loading...
View Options

sys/kern/kern_exit.c

Loading...
View Options

sys/kern/kern_kthread.c

Loading...
View Options

sys/kern/kern_racct.c

Loading...
View Options

sys/kern/kern_resource.c

Loading...
View Options

sys/kern/kern_thr.c

Loading...
View Options

sys/kern/kern_thread.c

Loading...
View Options

sys/kern/kern_umtx.c

Loading...
View Options

sys/kern/sched_4bsd.c

Loading...
View Options

sys/kern/sched_ule.c

Loading...
View Options

sys/sys/umtx.h

Loading...
View Options

sys/sys/umtxvar.h

Loading...