Page MenuHomeFreeBSD

umtx: Expose struct abs_timeout to the rest of the kernel.
ClosedPublic

Authored by dchagin on Tue, Jul 20, 7:21 PM.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kib added inline comments.
sys/kern/kern_umtx.c
767–768

I would rename the rest of the abs_timeout_ functions in this go as well, but this is your call.

This revision is now accepted and ready to land.Tue, Jul 20, 10:07 PM

done.

Add umtx_ prefix to all abs_timeout facility, add declaration for it.
For consistency with others abs_timeout functions mark inline abs_timeout_init2.

This revision now requires review to proceed.Tue, Jul 20, 10:40 PM
sys/kern/kern_umtx.c
263–266

I am not sure, but 'inline' is probably more important in declaration.

yes, I think you are right, moreover, inline should be droped from function as
the compiler can ignore the inline qualifier and generate calls to the function if
the code is compiled without optimization for example

This revision is now accepted and ready to land.Wed, Jul 21, 8:03 AM