Page MenuHomeFreeBSD

umtx: Expose struct abs_timeout to the rest of the kernel.
ClosedPublic

Authored by dchagin on Jul 20 2021, 7:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 14, 5:21 AM
Unknown Object (File)
Thu, Mar 7, 6:50 PM
Unknown Object (File)
Feb 19 2024, 12:36 AM
Unknown Object (File)
Feb 3 2024, 7:56 AM
Unknown Object (File)
Dec 20 2023, 4:44 AM
Unknown Object (File)
Dec 14 2023, 9:52 PM
Unknown Object (File)
Nov 10 2023, 12:36 AM
Unknown Object (File)
Nov 8 2023, 1:23 PM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40591
Build 37480: arc lint + arc unit

Event Timeline

kib added inline comments.
sys/kern/kern_umtx.c
767–768

I would rename the rest of the abs_timeout_ functions in this go as well, but this is your call.

This revision is now accepted and ready to land.Jul 20 2021, 10:07 PM

done.

Add umtx_ prefix to all abs_timeout facility, add declaration for it.
For consistency with others abs_timeout functions mark inline abs_timeout_init2.

This revision now requires review to proceed.Jul 20 2021, 10:40 PM
sys/kern/kern_umtx.c
263–266

I am not sure, but 'inline' is probably more important in declaration.

yes, I think you are right, moreover, inline should be droped from function as
the compiler can ignore the inline qualifier and generate calls to the function if
the code is compiled without optimization for example

This revision is now accepted and ready to land.Jul 21 2021, 8:03 AM