Page MenuHomeFreeBSD

umtx: Expose some of the umtx structures and API to the rest of the kernel.
ClosedPublic

Authored by dchagin on Tue, Jul 20, 2:08 PM.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I do not object against the idea of making more guts of kern_umtx.c usable for e.g. Linuxolator, but I think that polluting sys/umtx.h is not a right approach. I suggest to follow established practice, and add a new header, e.g. sys/umtxvar.h, where most of the stuff you moved could land.

More, I think that ideally you would move all the #ifdef _KERNEL bits from umtx.h to umtxvar.h, leaving umtx.h as ABI header for userspace.

Does it make sense?

sys/sys/umtx.h
187 ↗(On Diff #92488)

This is too generic name to expose in the reusable header. Please name it e.g. umtx_abs_timeout().

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Jul 29, 9:46 AM
This revision was automatically updated to reflect the committed changes.