Page MenuHomeFreeBSD
Differential D31233

umtx: Expose some of the umtx structures and API to the rest of the kernel.
ClosedPublic
Actions

Authored by dchagin on Jul 20 2021, 2:08 PM.
Tags
None
Referenced Files
F157013108: D31233.id92516.diff
Sun, May 17, 11:08 PM
F157013011: D31233.id92926.diff
Sun, May 17, 11:07 PM
F157013001: D31233.id92488.diff
Sun, May 17, 11:07 PM
F157009831: D31233.diff
Sun, May 17, 10:48 PM
Unknown Object (File)
Thu, May 7, 6:00 AM
Unknown Object (File)
Wed, May 6, 2:56 AM
Unknown Object (File)
Thu, Apr 30, 6:10 PM
Unknown Object (File)
Mon, Apr 27, 8:45 PM
View All Files
Subscribers
imp

Details

Reviewers
kib
markj
Commits
rG7642de029b56: umtx: Expose some of the umtx structures and API to the rest of the kernel.
rG1fdcc87cfd67: umtx: Expose some of the umtx structures and API to the rest of the kernel.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dchagin created this revision.Jul 20 2021, 2:08 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 20 2021, 2:08 PM
dchagin requested review of this revision.Jul 20 2021, 2:08 PM
Harbormaster completed remote builds in B40552: Diff 92488.Jul 20 2021, 2:08 PM
dchagin added reviewers: kib, markj.Jul 20 2021, 2:18 PM
dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
kib added a comment.Jul 20 2021, 4:25 PM

I do not object against the idea of making more guts of kern_umtx.c usable for e.g. Linuxolator, but I think that polluting sys/umtx.h is not a right approach. I suggest to follow established practice, and add a new header, e.g. sys/umtxvar.h, where most of the stuff you moved could land.

More, I think that ideally you would move all the #ifdef _KERNEL bits from umtx.h to umtxvar.h, leaving umtx.h as ABI header for userspace.

Does it make sense?

sys/sys/umtx.h
187 ↗(On Diff #92488)

This is too generic name to expose in the reusable header. Please name it e.g. umtx_abs_timeout().

dchagin updated this revision to Diff 92516.Jul 20 2021, 7:26 PM

agree, done, D31245 - D31249

Harbormaster completed remote builds in B40573: Diff 92516.Jul 20 2021, 7:26 PM
dchagin added parent revisions: D31248: umtx: Split umtx.h on two counterparts., D31249: umtx: Expose struct abs_timeout to the rest of the kernel..Jul 20 2021, 9:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 29 2021, 9:46 AM
Closed by commit rG1fdcc87cfd67: umtx: Expose some of the umtx structures and API to the rest of the kernel. (authored by dchagin). · Explain Why
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rG1fdcc87cfd67: umtx: Expose some of the umtx structures and API to the rest of the kernel..
dchagin added a commit: rG7642de029b56: umtx: Expose some of the umtx structures and API to the rest of the kernel..Jun 17 2022, 7:38 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
148 lines
sys/
134 lines

Diff 92926

View Options

sys/kern/kern_umtx.c

Loading...
View Options

sys/sys/umtxvar.h

Loading...