umtx: Expose some of the umtx structures and API to the rest of the kernel.
ClosedPublic
Actions

Authored by dchagin on Jul 20 2021, 2:08 PM.

Details

Reviewers

kib
markj

Commits

rG7642de029b56: umtx: Expose some of the umtx structures and API to the rest of the kernel.
rG1fdcc87cfd67: umtx: Expose some of the umtx structures and API to the rest of the kernel.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40552
Build 37441: arc lint + arc unit

Event Timeline

dchagin created this revision.Jul 20 2021, 2:08 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 20 2021, 2:08 PM

dchagin requested review of this revision.Jul 20 2021, 2:08 PM

Harbormaster completed remote builds in B40552: Diff 92488.Jul 20 2021, 2:08 PM

dchagin added reviewers: kib, markj.Jul 20 2021, 2:18 PM

dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

I do not object against the idea of making more guts of kern_umtx.c usable for e.g. Linuxolator, but I think that polluting sys/umtx.h is not a right approach. I suggest to follow established practice, and add a new header, e.g. sys/umtxvar.h, where most of the stuff you moved could land.

More, I think that ideally you would move all the #ifdef _KERNEL bits from umtx.h to umtxvar.h, leaving umtx.h as ABI header for userspace.

Does it make sense?