Page MenuHomeFreeBSD

ossl(4): Install the man page also for arm64
ClosedPublic

Authored by gbe on Apr 14 2021, 3:13 PM.

Details

Summary

In 22bd0c9731d7 ossl(4) was ported to arm64. The manual page was
adapted, but never installed since the ossl(4) manual page was
i386 / amd64 only.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

gbe requested review of this revision.Apr 14 2021, 3:13 PM

Thanks for catching this. I believe we generally prefer one block checking the supported MACHINE_CPUARCH values, like the _cgem.4 example below. Both styles are imperfect however.

Thanks for catching this. I believe we generally prefer one block checking the supported MACHINE_CPUARCH values, like the _cgem.4 example below. Both styles are imperfect however.

I would have reused this block, but ossl(4) doesn't support arm or riscv. If this doesn't matter, I could adapt the differential.

In D29762#667531, @gbe wrote:

Thanks for catching this. I believe we generally prefer one block checking the supported MACHINE_CPUARCH values, like the _cgem.4 example below. Both styles are imperfect however.

I would have reused this block, but ossl(4) doesn't support arm or riscv. If this doesn't matter, I could adapt the differential.

Sorry, I mean add a new block that checks for aarch64, amd64, or i386. Then, move the existing assignment to _ossl.4 to this new block.

  • Consolidate the MACHINE_CPUARCH block for ossl(4) man page
In D29762#667531, @gbe wrote:

Thanks for catching this. I believe we generally prefer one block checking the supported MACHINE_CPUARCH values, like the _cgem.4 example below. Both styles are imperfect however.

I would have reused this block, but ossl(4) doesn't support arm or riscv. If this doesn't matter, I could adapt the differential.

Sorry, I mean add a new block that checks for aarch64, amd64, or i386. Then, move the existing assignment to _ossl.4 to this new block.

Oh, okay, I have update the differential accordingly.

This revision is now accepted and ready to land.Apr 14 2021, 4:15 PM
This revision was automatically updated to reflect the committed changes.