Differential D28011

Refactor rt_addrmsg() and rt_routemsg().
ClosedPublic
Actions

Authored by melifaro on Jan 6 2021, 10:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 20, 7:01 PM

	Unknown Object (File)
	Mon, Apr 20, 7:47 AM

	Unknown Object (File)
	Mon, Apr 20, 4:46 AM

	Unknown Object (File)
	Sun, Apr 19, 10:02 AM

	Unknown Object (File)
	Sun, Apr 19, 12:45 AM

	Unknown Object (File)
	Sat, Apr 18, 10:02 PM

	Unknown Object (File)
	Fri, Apr 17, 1:26 PM

	Unknown Object (File)
	Mon, Apr 13, 3:11 PM

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

rGd68cf57b7f22: Refactor rt_addrmsg() and rt_routemsg().

Summary

Refactor rt_addrmsg(): make V_rt_add_addr_allfibs decision locally.
Fix rt_routemsg() and multipath by accepting nexthop instead of interface pointer.
Refactor rtsock_routemsg(): avoid accessing rtentry fields directly.
Simplify in_addprefix() by moving prefix search to a separate function.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

melifaro created this revision.Jan 6 2021, 10:57 PM

Herald added subscribers: bz, ae, imp. · View Herald TranscriptJan 6 2021, 10:57 PM

melifaro requested review of this revision.Jan 6 2021, 10:57 PM

Harbormaster completed remote builds in B35981: Diff 81780.Jan 6 2021, 10:57 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 7 2021, 7:39 PM

Closed by commit rGd68cf57b7f22: Refactor rt_addrmsg() and rt_routemsg(). (authored by melifaro). · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rGd68cf57b7f22: Refactor rt_addrmsg() and rt_routemsg()..

Revision Contents
Changeset List

Path

Size

sys/

net/

6 lines

17 lines

route/

1 line

15 lines

7 lines

16 lines

netinet/

46 lines

netinet6/

2 lines

18 lines

Diff 81829

sys/net/route.h

Loading...

sys/net/route.c

Loading...

sys/net/route/route_ctl.h

Loading...

sys/net/route/route_ctl.c

Loading...

sys/net/route/route_var.h

Loading...

sys/net/rtsock.c

Loading...

sys/netinet/in.c

Loading...

sys/netinet6/in6.c

Loading...

sys/netinet6/nd6_rtr.c

Loading...