Page MenuHomeFreeBSD

WIP: arm64: enable the ipmi module
ClosedPublic

Authored by mhorne on Jan 6 2021, 8:31 PM.

Details

Summary

Only ACPI attachment is supported for now, some others depend on smbios.

Test Plan

Compile module + kernel with options ipmi.

We should get someone with a supported machine to try it out.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mhorne requested review of this revision.Jan 6 2021, 8:31 PM
mhorne retitled this revision from arm64: enable the ipmi module to WIP: arm64: enable the ipmi module.Jan 6 2021, 9:05 PM
mhorne edited the summary of this revision. (Show Details)
sys/conf/files.arm64
363–366

Ah, this is a case where these should move to the common sys/conf/files

sys/modules/Makefile
605

I think there's a block for i386/amd64/arm64 already, and IMO we should put _ipmi in there

I wonder if there are machines that support any of the existing communication methods. eMAG would need acpi-i2c support…

sys/conf/files.arm64
363–366

We might need to be careful if these aren't needed on powerpc.

sys/modules/Makefile
605

It's also built on powerpc.

sys/modules/ipmi/Makefile
26–29

Could we merge the arm64 and x86 sections to reduce this duplication?

sys/conf/files.arm64
363–366

Oh yes, fair point.

This revision is now accepted and ready to land.Jan 7 2021, 3:55 PM

Reorder SRCS blocks in ipmi/Makefile. Set _ipmi in arm64/amd64/i386 block (powerpc64 block untouched).

This revision now requires review to proceed.Jan 7 2021, 5:07 PM

I wonder if there are machines that support any of the existing communication methods. eMAG would need acpi-i2c support…

It's possible that there aren't any, enabling this now will help vendors confirm that. Certainly there is more to be done in this area.

sys/conf/files.arm64
363–366

Yeah, it is only ipmi.c that is common to all, so I opted just to duplicate it.

sys/modules/Makefile
605

I moved it to the other block but left powerpc alone. As usual with this file there is no winning.

This revision is now accepted and ready to land.Jan 7 2021, 7:22 PM
This revision was automatically updated to reflect the committed changes.