sys/conf/files.arm64
364–367	Ah, this is a case where these should move to the common sys/conf/files
sys/modules/Makefile
606	I think there's a block for i386/amd64/arm64 already, and IMO we should put _ipmi in there

I wonder if there are machines that support any of the existing communication methods. eMAG would need acpi-i2c support…

andrew added inline comments.Jan 7 2021, 12:51 PM

sys/conf/files.arm64
364–367	We might need to be careful if these aren't needed on powerpc.
sys/modules/Makefile
606	It's also built on powerpc.
sys/modules/ipmi/Makefile
27–30	Could we merge the arm64 and x86 sections to reduce this duplication?

emaste added inline comments.Jan 7 2021, 1:46 PM

sys/conf/files.arm64
364–367	Oh yes, fair point.

emaste accepted this revision.Jan 7 2021, 3:55 PM

This revision is now accepted and ready to land.Jan 7 2021, 3:55 PM

Reorder SRCS blocks in ipmi/Makefile. Set _ipmi in arm64/amd64/i386 block (powerpc64 block untouched).

This revision now requires review to proceed.Jan 7 2021, 5:07 PM

Harbormaster completed remote builds in B35998: Diff 81819.Jan 7 2021, 5:07 PM

In D28009#625638, @greg_unrelenting.technology wrote:

I wonder if there are machines that support any of the existing communication methods. eMAG would need acpi-i2c support…

It's possible that there aren't any, enabling this now will help vendors confirm that. Certainly there is more to be done in this area.

sys/conf/files.arm64
364–367	Yeah, it is only `ipmi.c` that is common to all, so I opted just to duplicate it.
sys/modules/Makefile
606	I moved it to the other block but left powerpc alone. As usual with this file there is no winning.