Differential D27887

hid: Import functions and constants required by new subsystem
ClosedPublic
Actions

Authored by wulf on Jan 2 2021, 11:12 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 8:40 AM

	Unknown Object (File)
	Mon, Dec 16, 5:32 PM

	Unknown Object (File)
	Sun, Dec 8, 6:13 PM

	Unknown Object (File)
	Nov 8 2024, 9:04 PM

	Unknown Object (File)
	Oct 24 2024, 7:02 PM

	Unknown Object (File)
	Oct 4 2024, 10:04 AM

	Unknown Object (File)
	Oct 4 2024, 5:10 AM

	Unknown Object (File)
	Sep 30 2024, 5:16 PM

View All 57 Files

Subscribers

Details

Reviewers

• hselasky
markj
avg
imp
val_packett.cool
manu

Commits

rG197587867321: hid: Import functions and constants required by new subsystem

Summary

This does an import of quirk stubs, debugging macros from USB code and numerous usage constants used by dependent drivers.

Besides that, this change renames some function to get a better match with userland library and NetBSD/OpenBSD HID code.
Namely:

Old hid_report_size() renamed to hid_report_size_max()
New hid_report_size() calculates size of given report rather than maximum size of all reports.
hid_get_data_unsigned() renamed tp hid_get_udata()
hid_put_data_unsigned() renamed to hid_put_udata()

Compatibility shims hidden under COMPAT_USBHID12 #define are provided in usbhid.h to make possible compiling of old code unmodified after this change.

The revision is subset of https://reviews.freebsd.org/D27777

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wulf created this revision.Jan 2 2021, 11:12 AM

Herald added subscribers: jhibbits, emaste, andrew. · View Herald TranscriptJan 2 2021, 11:12 AM

wulf requested review of this revision.Jan 2 2021, 11:12 AM

wulf edited the summary of this revision. (Show Details)Jan 2 2021, 11:50 AM

Looks good!

This revision is now accepted and ready to land.Jan 2 2021, 12:50 PM

manu accepted this revision.Jan 2 2021, 1:00 PM

emaste added inline comments.Jan 2 2021, 3:43 PM

sys/amd64/conf/GENERIC
385	Is the intent that we'll leave these enabled indefinitely, or only during initial work?

manu added inline comments.Jan 2 2021, 3:47 PM

sys/amd64/conf/GENERIC
385	It's like USB_DEBUG so it will be present in GENERIC but can be turned off via nooptions.

Closed by commit rG197587867321: hid: Import functions and constants required by new subsystem (authored by wulf). · Explain WhyJan 7 2021, 11:22 PM

This revision was automatically updated to reflect the committed changes.

wulf mentioned this in rGeead9017d283: hid: Chase for HID function name changes in existing USB HID drivers.

wulf added a commit: rG197587867321: hid: Import functions and constants required by new subsystem.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

conf/

1 line

arm64/

conf/

1 line

GENERIC-NODEBUG

1 line

conf/

3 lines

dev/

hid/

110 lines

168 lines

74 lines

usb/

20 lines

i386/

conf/

1 line

mips/

conf/

1 line

1 line

1 line

modules/

hid/

hid/

2 lines

powerpc/

conf/

1 line

1 line

1 line

1 line

1 line

1 line

Diff 81845

sys/amd64/conf/GENERIC

Loading...

sys/arm64/conf/GENERIC

Loading...

sys/arm64/conf/GENERIC-NODEBUG

Loading...

sys/conf/options

Loading...

sys/dev/hid/hid.h

Loading...

sys/dev/hid/hid.c

Loading...

sys/dev/hid/hidquirk.h

Loading...

sys/dev/usb/usbhid.h

Loading...

sys/i386/conf/GENERIC

Loading...

sys/mips/conf/ERL

Loading...

sys/mips/conf/JZ4780

Loading...

sys/mips/conf/OCTEON1

Loading...

sys/modules/hid/hid/Makefile

Loading...

sys/powerpc/conf/GENERIC

Loading...

sys/powerpc/conf/GENERIC64

Loading...

sys/powerpc/conf/GENERIC64LE

Loading...

sys/powerpc/conf/MPC85XX

Loading...

sys/powerpc/conf/MPC85XXSPE

Loading...

sys/powerpc/conf/QORIQ64

Loading...