Page MenuHomeFreeBSD

GSoC AdminsGroup
ActivePublic

Watchers

  • This project does not have any watchers.

Recent Activity

Aug 19 2019

D20967: new MAC policy module - mac_ipacl is now accepted and ready to land.
Aug 19 2019, 1:22 PM · GSoC Students, GSoC Admins

Aug 9 2019

shivank updated the diff for D20967: new MAC policy module - mac_ipacl.
Aug 9 2019, 6:54 PM · GSoC Students, GSoC Admins
shivank added a comment to D20967: new MAC policy module - mac_ipacl.
  • correct the IP addresses which were not in the documentation range
Aug 9 2019, 5:42 PM · GSoC Students, GSoC Admins
bz added a comment to D20967: new MAC policy module - mac_ipacl.

There's a couple of public IP(v6) addresses in the test scripts. We'd prefer not to have accidents with people. Can you please change them?

Aug 9 2019, 8:53 AM · GSoC Students, GSoC Admins

Aug 6 2019

shivank added a comment to D20967: new MAC policy module - mac_ipacl.
  • add ipacl entry in tests Makefile
  • fix minor issues in mac_ipacl.4
Aug 6 2019, 4:26 PM · GSoC Students, GSoC Admins

Aug 3 2019

shivank updated the diff for D20967: new MAC policy module - mac_ipacl.
Aug 3 2019, 9:43 AM · GSoC Students, GSoC Admins
shivank added a comment to D20967: new MAC policy module - mac_ipacl.
  • make tests more structured with atf
  • update man page mac_ipacl.4
Aug 3 2019, 9:29 AM · GSoC Students, GSoC Admins

Jul 31 2019

shivank added a comment to D20967: new MAC policy module - mac_ipacl.

fix errors shown by mandoc -Tlint for mac_ipacl.4
fix the license and copyrights

Jul 31 2019, 7:17 PM · GSoC Students, GSoC Admins
shivank added a comment to D20967: new MAC policy module - mac_ipacl.

Hi, @0mp thanks for the suggestion :).

Jul 31 2019, 6:54 PM · GSoC Students, GSoC Admins
0mp added a comment to D20967: new MAC policy module - mac_ipacl.

You may also want to run mandoc -Tlint apart from igor. :)

Jul 31 2019, 3:42 PM · GSoC Students, GSoC Admins

Jul 30 2019

bz added inline comments to D20967: new MAC policy module - mac_ipacl.
Jul 30 2019, 10:59 PM · GSoC Students, GSoC Admins

Jul 28 2019

shivank added a comment to D20967: new MAC policy module - mac_ipacl.
  • move man page to its right place
Jul 28 2019, 7:01 PM · GSoC Students, GSoC Admins

Jul 25 2019

shivank added inline comments to D20967: new MAC policy module - mac_ipacl.
Jul 25 2019, 1:56 PM · GSoC Students, GSoC Admins
shivank added a comment to D20967: new MAC policy module - mac_ipacl.
  • Correct the license file for mac_ipacl.c and mac_ipacl.4
  • fix Kyua for test shell scripts
  • fix errors in mac_ipacl.4 man page
Jul 25 2019, 1:52 PM · GSoC Students, GSoC Admins

Jul 24 2019

bz added a comment to D20967: new MAC policy module - mac_ipacl.

Grat work on the cleanup; I think apart from the license there is very few minor nits left which are acceptable.

Jul 24 2019, 1:34 PM · GSoC Students, GSoC Admins

Jul 22 2019

bz added a comment to D20967: new MAC policy module - mac_ipacl.

I have a few doubts:

  • I'm not clear about the license, should the TrustedBSD be included? if yes, then how? Also, I have copied the sysctl_rules from mac_portacl, Is it infringing any copyright as of now? I've read BSD license is very open, can I mention the mac_portacl?
Jul 22 2019, 2:11 PM · GSoC Students, GSoC Admins
shivank added a comment to D20967: new MAC policy module - mac_ipacl.

I have a few doubts:

  • I'm not clear about the license, should the TrustedBSD be included? if yes, then how? Also, I have copied the sysctl_rules from mac_portacl, Is it infringing any copyright as of now? I've read BSD license is very open, can I mention the mac_portacl?
  • should #ifdef INET/INET6 be put in mac_policy.h and mac_framework.h?
  • after adding INET/INET6 in mac_ipacl, kyua stopped working for test scripts. It gives errors as "ip4_test:main -> broken: Received signal 6 [0.033s] ip6_test:main -> broken: Received signal 6 [0.032s]" As scripts they are testing fine.
Jul 22 2019, 1:14 PM · GSoC Students, GSoC Admins
Herald added a reviewer for D20967: new MAC policy module - mac_ipacl: manpages.

fix style issues
fix copyright issue

Jul 22 2019, 12:54 PM · GSoC Students, GSoC Admins
D20967: new MAC policy module - mac_ipacl now requires changes to proceed.

Hey, thank you for all the updates. There are a few more. Please let me know when you think you are done with all of them and I'll have a full look again.

Jul 22 2019, 10:36 AM · GSoC Students, GSoC Admins
shivank added a comment to D20967: new MAC policy module - mac_ipacl.

add #ifdef INET and #ifdef in INET6
fix indentation and style issues
add mac_ipacl entry in kernel conf and modules Makefile

Jul 22 2019, 7:41 AM · GSoC Students, GSoC Admins

Jul 19 2019

shivank added a comment to D20967: new MAC policy module - mac_ipacl.

Add copyright and license.
Add a man page for mac_ipacl

Jul 19 2019, 6:49 PM · GSoC Students, GSoC Admins
shivank added a comment to D20967: new MAC policy module - mac_ipacl.

indentation and style changes,
moved subnet check code from rules_check to parser,

Jul 19 2019, 7:52 AM · GSoC Students, GSoC Admins
shivank added inline comments to D20967: new MAC policy module - mac_ipacl.
Jul 19 2019, 7:23 AM · GSoC Students, GSoC Admins

Jul 17 2019

bz added a comment to D20967: new MAC policy module - mac_ipacl.

I think sys/security/mac_ipacl/design_notes.txt and sys/security/mac_ipacl/notes.txt can be removed. Should be turned into a man page really!?

Jul 17 2019, 10:42 AM · GSoC Students, GSoC Admins

Jul 16 2019

shivank updated the diff for D20967: new MAC policy module - mac_ipacl.
Jul 16 2019, 10:09 AM · GSoC Students, GSoC Admins
shivank added a comment to D20967: new MAC policy module - mac_ipacl.

correct the diff file

Jul 16 2019, 9:57 AM · GSoC Students, GSoC Admins
shivank created D20967: new MAC policy module - mac_ipacl.
Jul 16 2019, 9:49 AM · GSoC Students, GSoC Admins