User Details
- User Since
- Jul 15 2019, 7:35 AM (154 w, 3 d)
Jan 21 2021
Sep 12 2020
Sep 11 2020
Sep 10 2020
I feel vfs_cache.c changes for making vn_fullpath_global work for optionally locked vnode are causing the trouble. Though I'm not sure what's the problem. I request Mateusz Guzik, @mjg to have a look at my vfs_cache.c changes. I would be grateful for your time.
Sep 7 2020
- merge vn_fullpath_any and vn_vptocnp with their locked counterpart to work for optionally locked vnodes.
Aug 31 2020
I created a new review - D26243. Sorry for the trouble.
It was earlier being reviewed on D25869. But due to change of base revision, It was showing changes which were not mine. So, I created a new review here.
Aug 30 2020
It looks like your most recent change rebased the base revision. That makes it very hard to see which changes are from you and which aren't. Could you please either un-rebase it or, if that's not possible, open a new review?
Aug 28 2020
- updated sys/kern/vfs_cache.c to reduce code duplication with vn_fullpath_dir
- some trivial changes
Aug 20 2020
Regarding code duplication in vn_fullpath_dir_locked:
I modified vn_fullpath_dir(and removed vn_fullpath_dir_locked) for optionally locked vnode here in git commit: https://github.com/shivankgarg98/freebsd/commit/418c1c2a6de9989fe7a541f6111ee2c3f2786c7b
It works fine NFSv4=3 case but somehow breaks nfsrvd_open to result in an error.{and hence can't open/create a regular file from client}.
Using two completely separate functions reduces the scope of error. Also prevent any mutation to the current code path for not locked vnodes, while allowing it to work for locked vnodes.
follow-up on suggested changes.
Aug 4 2020
removing unlocking/relocking implementation for vnode for auditing path, instead, define separate functions in vfs_cache.c for locked vnode as argument.
Jul 30 2020
Thanks for all suggestions. I have incorporated them into my code. There is just a directory vnode unlocking/relocking issue not done yet.
Jul 29 2020
follow up on changes suggested by asomers@
Jul 28 2020
Jun 16 2020
Jun 15 2020
Please re-review it,
I updated the diff after removing the vnode_mount macro as suggested by Rick.
Jun 14 2020
Aug 9 2019
- correct the IP addresses which were not in the documentation range
Aug 6 2019
- add ipacl entry in tests Makefile
- fix minor issues in mac_ipacl.4
Aug 3 2019
- make tests more structured with atf
- update man page mac_ipacl.4
Jul 31 2019
fix errors shown by mandoc -Tlint for mac_ipacl.4
fix the license and copyrights
Hi, @0mp thanks for the suggestion :).
Jul 28 2019
- move man page to its right place
Jul 25 2019
- Correct the license file for mac_ipacl.c and mac_ipacl.4
- fix Kyua for test shell scripts
- fix errors in mac_ipacl.4 man page
Jul 22 2019
I have a few doubts:
- I'm not clear about the license, should the TrustedBSD be included? if yes, then how? Also, I have copied the sysctl_rules from mac_portacl, Is it infringing any copyright as of now? I've read BSD license is very open, can I mention the mac_portacl?
- should #ifdef INET/INET6 be put in mac_policy.h and mac_framework.h?
- after adding INET/INET6 in mac_ipacl, kyua stopped working for test scripts. It gives errors as "ip4_test:main -> broken: Received signal 6 [0.033s] ip6_test:main -> broken: Received signal 6 [0.032s]" As scripts they are testing fine.
fix style issues
fix copyright issue
add #ifdef INET and #ifdef in INET6
fix indentation and style issues
add mac_ipacl entry in kernel conf and modules Makefile
Jul 19 2019
Add copyright and license.
Add a man page for mac_ipacl
indentation and style changes,
moved subnet check code from rules_check to parser,
Jul 16 2019
correct the diff file