Page MenuHomeFreeBSD

portmgrGroup
ActivePublic

Details

Description

The port management team

Recent Activity

Jul 31 2025

rene added a member for portmgr: dvl.
Jul 31 2025, 1:55 PM

Jul 23 2025

imp added a comment to D51414: Mk/Scripts: Add SPDX license file normalizer and matcher.

My only other feedback from looking at the draft standard was that while we should have LicenseRef-Foo as described in the document, each time we have to do that because the matching score isn't high enough, we should encourage the maintainer to submit that to the SPDX legal team so that they can either tweak the markup for license Foo, or create a new Foo variant if the changes are legally different enough.

Jul 23 2025, 7:45 PM · portmgr
tuukka.pasanen_ilmi.fi added a comment to D51414: Mk/Scripts: Add SPDX license file normalizer and matcher.

I've tested few random packages in ports.

  • It's bit confusing that check-spdx-license compiles things when one might just want to check license. What I mean is that it should just extract and check license file in current port directory not try to compile whole package?

I think that is what this is doing. It's extracting and checking the license. There is no compiling involved.

Then is just me.. I find it confusing in some tested ports like Go ones just print so much stuff and it looks like it starts compile something.

Jul 23 2025, 7:43 AM · portmgr

Jul 22 2025

bofh added a comment to D51414: Mk/Scripts: Add SPDX license file normalizer and matcher.

I've tested few random packages in ports.

  • It's bit confusing that check-spdx-license compiles things when one might just want to check license. What I mean is that it should just extract and check license file in current port directory not try to compile whole package?

I think that is what this is doing. It's extracting and checking the license. There is no compiling involved.

  • Another one what might be easier to user to understand would be if match is 1.0 (I understood that is 100%) it should not be relevant to show other possible licenses?

Yes I have that code hidden and commented around somewhere still in the scripts and waiting for some other's feedback

  • It would be nice to see unified diff if license differs from license that is mentioned in ports Makefile.

This is not easy to do. Initially we are actually normalizing the entire documents into a single line to avoid any ambiguity. So the unified diff is not helpful as it prints two huge lines. To have something really readable we have to break into lines again. I will look into it but no promises.

Jul 22 2025, 10:21 AM · portmgr
tuukka.pasanen_ilmi.fi added a comment to D51414: Mk/Scripts: Add SPDX license file normalizer and matcher.

I've tested few random packages in ports.

Jul 22 2025, 9:04 AM · portmgr

Jul 19 2025

bofh updated the diff for D51414: Mk/Scripts: Add SPDX license file normalizer and matcher.

Fix some corner cases of normalization.

Jul 19 2025, 11:09 AM · portmgr

Jul 18 2025

bofh requested review of D51414: Mk/Scripts: Add SPDX license file normalizer and matcher.
Jul 18 2025, 9:06 PM · portmgr

Dec 31 2024

bofh closed D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.
Dec 31 2024, 7:43 AM · portmgr
mat added a comment to D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.

Great, thank you for this work.

Dec 31 2024, 6:45 AM · portmgr

Dec 30 2024

bofh added a comment to D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.

I do have the necessary CHANGES entry just not attached it here for keeping it clutter free. I will rerun one more mini exp tomorrow and commit.

Dec 30 2024, 8:25 PM · portmgr
mat added a comment to D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.

Whatever is in the review description will do just fine for the CHANGES entry.

Dec 30 2024, 8:23 PM · portmgr
mat added a comment to D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.

Oh, please add a entry to the CHANGES file too.

Dec 30 2024, 8:20 PM · portmgr
mat accepted D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.

Approved as long as it's been tested with a "today" ports tree. ("today" being regarding to the day it will being pushed.)

Dec 30 2024, 8:11 PM · portmgr

Dec 29 2024

bofh added a comment to D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.

I can hold off branching 2025Q1

Dec 29 2024, 5:58 PM · portmgr
rene added a comment to D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.

I can hold off branching 2025Q1

Dec 29 2024, 5:57 PM · portmgr

Dec 28 2024

freebsd_dev.thsi.be accepted D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.

I've created https://reviews.freebsd.org/D48228
You can see there how I intended to re-do the USE_OCAML_LDCONFIG. I've been testingthat patch on 15amd64 and 13.3 armv7, everything build fine with the exception of math/coq which fails to build the documentation on armv7...

One other thing in that patch is the removal of USE_OCAMLFIND_PLIST, which make the bsd.ocaml.mk to Uses/ocaml.mk transistion less complicated. USE_OCAMLFIND_PLIST isn't really that useful, to the contrary it makes packaging error more likely (e.g. disabling a feature, not noticing less files are packages), so i think it is better to remove it.

Thanks for the work. Unfortunately due to the holidays and everything it's difficult to count maintainer-timeout and commit some of those patches.

Dec 28 2024, 10:51 PM · portmgr
bofh updated the diff for D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.
Dec 28 2024, 10:27 PM · portmgr
bofh updated the diff for D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.
Dec 28 2024, 10:24 PM · portmgr
bofh added a comment to D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.

I've created https://reviews.freebsd.org/D48228
You can see there how I intended to re-do the USE_OCAML_LDCONFIG. I've been testingthat patch on 15amd64 and 13.3 armv7, everything build fine with the exception of math/coq which fails to build the documentation on armv7...

One other thing in that patch is the removal of USE_OCAMLFIND_PLIST, which make the bsd.ocaml.mk to Uses/ocaml.mk transistion less complicated. USE_OCAMLFIND_PLIST isn't really that useful, to the contrary it makes packaging error more likely (e.g. disabling a feature, not noticing less files are packages), so i think it is better to remove it.

Dec 28 2024, 10:15 PM · portmgr
bofh updated the summary of D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.
Dec 28 2024, 10:09 PM · portmgr
bofh updated the diff for D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.

Here is the updated patch which converts everything from bsd.ocaml.mk to args for USES=ocaml. See the summary.

Dec 28 2024, 10:07 PM · portmgr
freebsd_dev.thsi.be added a comment to D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.

I've created https://reviews.freebsd.org/D48228
You can see there how I intended to re-do the USE_OCAML_LDCONFIG. I've been testingthat patch on 15amd64 and 13.3 armv7, everything build fine with the exception of math/coq which fails to build the documentation on armv7...

Dec 28 2024, 8:25 PM · portmgr
freebsd_dev.thsi.be added a comment to D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.

Hi,

We should have moved out of Mk/bsd.*.mk (except the obvious ones) maybe a decade ago and these are just some technical debts in the Mk directory. :)

So I am just trying to clear of the Mk directory and I plan to merge this before the next quarterly split. [...]

I am still trying to convert some other keywords into args.

Dec 28 2024, 8:20 PM · portmgr
bofh added a comment to D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.

We should have moved out of Mk/bsd.*.mk (except the obvious ones) maybe a decade ago and these are just some technical debts in the Mk directory. :)

Dec 28 2024, 6:28 PM · portmgr
freebsd_dev.thsi.be added inline comments to D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.
Dec 28 2024, 6:21 PM · portmgr
bofh updated the diff for D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.
Dec 28 2024, 6:16 PM · portmgr
bofh updated the diff for D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.
Dec 28 2024, 5:49 PM · portmgr
bofh updated the diff for D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.
Dec 28 2024, 5:30 PM · portmgr
bofh requested review of D48227: Mk/**ocaml.mk: Convert remaining bsd.ocaml.mk to Uses/ocaml.mk.
Dec 28 2024, 4:47 PM · portmgr

May 22 2024

yan.jurak_gmail.com removed a watcher for portmgr: yan.jurak_gmail.com.
May 22 2024, 9:09 PM

May 20 2024

yan.jurak_gmail.com added a watcher for portmgr: yan.jurak_gmail.com.
May 20 2024, 10:19 PM

Mar 22 2024

vvd closed D44228: Mk/bsd.options.mk: add possibility set default options for other (not defined in port) arches.
Mar 22 2024, 6:44 PM · portmgr
arrowd accepted D44228: Mk/bsd.options.mk: add possibility set default options for other (not defined in port) arches.
Mar 22 2024, 5:43 PM · portmgr

Mar 21 2024

vvd added a comment to D44228: Mk/bsd.options.mk: add possibility set default options for other (not defined in port) arches.

The full list of arches is here: https://www.freebsd.org/platforms/

Mar 21 2024, 11:42 AM · portmgr
vvd added a comment to D44228: Mk/bsd.options.mk: add possibility set default options for other (not defined in port) arches.

ping again

Mar 21 2024, 9:31 AM · portmgr

Mar 20 2024

bofh removed a member for portmgr: bofh.
Mar 20 2024, 1:42 PM

Mar 19 2024

bofh added inline comments to D44410: Mk/bsd.port.mk: Override Uses/*.Mk with overlays.
Mar 19 2024, 6:09 PM · portmgr
mat added inline comments to D44410: Mk/bsd.port.mk: Override Uses/*.Mk with overlays.
Mar 19 2024, 5:54 PM · portmgr
bofh updated the diff for D44410: Mk/bsd.port.mk: Override Uses/*.Mk with overlays.

Update diff with more context

Mar 19 2024, 5:45 PM · portmgr
mat added a comment to D44410: Mk/bsd.port.mk: Override Uses/*.Mk with overlays.

Can you re-upload the diff with arcanist or by generating the diff with more context, like arcanist does (git diff -U9999)

Mar 19 2024, 5:42 PM · portmgr

Mar 18 2024

bofh retitled D44410: Mk/bsd.port.mk: Override Uses/*.Mk with overlays from Mk/bsd.port.mk: Override USES/*.Mk with overlays to Mk/bsd.port.mk: Override Uses/*.Mk with overlays.
Mar 18 2024, 9:53 PM · portmgr
arrowd accepted D44410: Mk/bsd.port.mk: Override Uses/*.Mk with overlays.

LGTM, but I didn't run-test this, as I don't use overlays.

Mar 18 2024, 4:12 PM · portmgr
bofh added inline comments to D44410: Mk/bsd.port.mk: Override Uses/*.Mk with overlays.
Mar 18 2024, 3:54 PM · portmgr
arrowd added inline comments to D44410: Mk/bsd.port.mk: Override Uses/*.Mk with overlays.
Mar 18 2024, 3:52 PM · portmgr
bofh requested review of D44410: Mk/bsd.port.mk: Override Uses/*.Mk with overlays.
Mar 18 2024, 3:39 PM · portmgr

Mar 16 2024

vvd added inline comments to D44228: Mk/bsd.options.mk: add possibility set default options for other (not defined in port) arches.
Mar 16 2024, 7:21 PM · portmgr
vvd updated the diff for D44228: Mk/bsd.options.mk: add possibility set default options for other (not defined in port) arches.
Mar 16 2024, 7:21 PM · portmgr
mat added inline comments to D44228: Mk/bsd.options.mk: add possibility set default options for other (not defined in port) arches.
Mar 16 2024, 5:50 PM · portmgr
vvd added a comment to D44228: Mk/bsd.options.mk: add possibility set default options for other (not defined in port) arches.

ping

Mar 16 2024, 5:19 PM · portmgr

Mar 7 2024

bofh closed D44156: Mk/Scripts: Add qa warning while installing man pages is ${PREFIX}/man.

Not sure why but somehow I believe I failed to add this as the review in my commit message. This has already landed.

Mar 7 2024, 4:53 PM · portmgr