Forgot to add "Differential Revision" in commit message.
https://cgit.freebsd.org/ports/commit/?id=3f1b38acfda124fc8f03fe5f4edfef10ef214501
https://cgit.freebsd.org/ports/commit/?h=2023Q3&id=fc4ebc143c4b097ec1ea90fa6831a3125c8619de

That's a good cleanup, thanks!

Update patch with git diff -U10000.

(Some of these are comments because Phabricator seems to prevent suggestions for this review.)

Tested build:
emulators/virtualbox-ose: poudriere and64 12.4, 13.1, 13.2; live 13.2.
emulators/virtualbox-ose-legacy: poudriere and64 and i386 12.4, 13.1, 13.2.

I've been using this change since at least start of May 2022, so for more than one year, on about 5 points of 13-STABLE, including a very recent one, and with lots of virtual machines.

Did you conduct run-testing for this change?

In D40408#920320, @vvd wrote:

I understood you correctly?

I understood you correctly?

could you please add explicit paranthesis in this part (${OSVERSION} < 1302505 || ${OSVERSION} >= 1400000 && ${OSVERSION} < 1400079)

… Need last test: build with llvm15 from base and run on 14-CURRENT and 13-STABLE amd64 …

In D40254#917734, @grahamperrin wrote:

https://www.freshports.org/emulators/virtualbox-ose/#history is currently at 6.1.44_1.

https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-naming-revepoch – if I understand correctly, D40254 should bump the PORTREVISION from 1 to 2 at line 3.

Tested and works on a recent 14-CURRENT.

https://www.freshports.org/emulators/virtualbox-ose/#history is currently at 6.1.44_1.