Page MenuHomeFreeBSD

tuexen (Michael Tuexen)
User

Projects

User Details

User Since
Feb 4 2016, 4:45 PM (470 w, 6 d)

Recent Activity

Yesterday

tuexen accepted D48967: cc_cubic: remove redundant calls of tcp_fixed_maxseg().
Wed, Feb 12, 5:28 PM
tuexen committed rGe1dd07ede923: icmp: use per rate limit randomized jitter (authored by tuexen).
icmp: use per rate limit randomized jitter
Wed, Feb 12, 2:08 PM
tuexen committed rGbd6a89a6c32a: icmp: improve INVARIANTS check (authored by tuexen).
icmp: improve INVARIANTS check
Wed, Feb 12, 2:07 PM
tuexen committed rG1b4561cf4b46: icmp: correct the assertion that checks limit + jitter (authored by glebius).
icmp: correct the assertion that checks limit + jitter
Wed, Feb 12, 2:06 PM
tuexen committed rG0b29ef1e3fd5: icmp: allow zero value for ICMP limits (authored by glebius).
icmp: allow zero value for ICMP limits
Wed, Feb 12, 2:05 PM
tuexen committed rG1cc0ac5ef37e: icmp6: bring rate limiting on a par with IPv4 (authored by glebius).
icmp6: bring rate limiting on a par with IPv4
Wed, Feb 12, 2:03 PM
tuexen committed rG90ecc3fc679d: icmp6: rate limit our echo replies (authored by glebius).
icmp6: rate limit our echo replies
Wed, Feb 12, 10:30 AM
tuexen committed rGdc167e64dce3: icmp6: make icmp6_ratelimit() responsible to update the stats counter (authored by glebius).
icmp6: make icmp6_ratelimit() responsible to update the stats counter
Wed, Feb 12, 10:28 AM
tuexen committed rG18058544c65b: icmp: improve ICMP limit jitter (authored by glebius).
icmp: improve ICMP limit jitter
Wed, Feb 12, 10:24 AM
tuexen committed rGa71eee300ba7: icmp: when logging ICMP ratelimiting message use correct jitter value (authored by glebius).
icmp: when logging ICMP ratelimiting message use correct jitter value
Wed, Feb 12, 10:23 AM
tuexen committed rGa6d5c6a04fe9: icmp: hide icmp_bandlimit_uninit() under VIMAGE (authored by glebius).
icmp: hide icmp_bandlimit_uninit() under VIMAGE
Wed, Feb 12, 10:22 AM
tuexen committed rG0939f3a04653: icmp: do not store per-VNET identical array of strings (authored by glebius).
icmp: do not store per-VNET identical array of strings
Wed, Feb 12, 10:20 AM
tuexen committed rGccd9c1ef4e90: icmp: use per rate limit randomized jitter (authored by tuexen).
icmp: use per rate limit randomized jitter
Wed, Feb 12, 10:05 AM

Mon, Feb 10

tuexen committed rG923c223f27e7: icmp: use per rate limit randomized jitter (authored by tuexen).
icmp: use per rate limit randomized jitter
Mon, Feb 10, 9:21 PM
tuexen closed D48804: icmp: use per rate limit randomized jitter.
Mon, Feb 10, 9:21 PM

Wed, Feb 5

tuexen committed rGdc66be9b6258: TCP BBR: remove dead code (authored by tuexen).
TCP BBR: remove dead code
Wed, Feb 5, 9:04 PM
tuexen committed rGf28415489639: TCP BBR: remove dead code (authored by tuexen).
TCP BBR: remove dead code
Wed, Feb 5, 9:04 PM
tuexen committed rG3cf7769f1f18: TCP RACK: don't log an uninitialized value (authored by tuexen).
TCP RACK: don't log an uninitialized value
Wed, Feb 5, 9:03 PM
tuexen committed rG0cc48e631781: TCP RACK: don't log an uninitialized value (authored by tuexen).
TCP RACK: don't log an uninitialized value
Wed, Feb 5, 9:00 PM
tuexen committed rG992f67691ada: TCP RACK: fix TCP_RACK_PACING_BETA socket option (authored by tuexen).
TCP RACK: fix TCP_RACK_PACING_BETA socket option
Wed, Feb 5, 8:58 PM
tuexen committed rG88844461a715: TCP BBR: remove dead code (authored by tuexen).
TCP BBR: remove dead code
Wed, Feb 5, 8:57 PM
tuexen committed rGc6f745a3e334: TCP BBR: remove dead code (authored by tuexen).
TCP BBR: remove dead code
Wed, Feb 5, 8:57 PM
tuexen committed rG7edc7c8f6f97: TCP BBR: remove dead code (authored by tuexen).
TCP BBR: remove dead code
Wed, Feb 5, 8:56 PM
tuexen committed rG2a704e9ca7e9: TCP BBR: remove dead code (authored by tuexen).
TCP BBR: remove dead code
Wed, Feb 5, 8:55 PM
tuexen committed rG9698788212e8: TCP RACK: fix TCP fast open (authored by tuexen).
TCP RACK: fix TCP fast open
Wed, Feb 5, 8:55 PM
tuexen committed rG86ec7e524a5d: TCP RACK: fix TCP fast open (authored by tuexen).
TCP RACK: fix TCP fast open
Wed, Feb 5, 8:54 PM
tuexen committed rG1d8bbe5ba370: TCP RACK: remove variable with is only initialized and not changed (authored by tuexen).
TCP RACK: remove variable with is only initialized and not changed
Wed, Feb 5, 8:53 PM
tuexen committed rG264b7dd11fa1: TCP BBR: remove code which is not needed (authored by tuexen).
TCP BBR: remove code which is not needed
Wed, Feb 5, 8:51 PM
tuexen committed rG6ab740bc90c1: TCP BBR: remove code which is not needed (authored by tuexen).
TCP BBR: remove code which is not needed
Wed, Feb 5, 8:51 PM
tuexen committed rG4f5788dfca2b: TCP BBR: simplify expression (authored by tuexen).
TCP BBR: simplify expression
Wed, Feb 5, 8:50 PM
tuexen committed rG2632e532c431: TCP BBR: simplify expression (authored by tuexen).
TCP BBR: simplify expression
Wed, Feb 5, 8:50 PM
tuexen committed rG221ac9e07859: TCP RACK: remove code that cannot be reached (authored by tuexen).
TCP RACK: remove code that cannot be reached
Wed, Feb 5, 8:49 PM
tuexen committed rGed530aaa4722: TCP BBR: fix integer overflow (authored by tuexen).
TCP BBR: fix integer overflow
Wed, Feb 5, 8:47 PM
tuexen committed rGc178bc193490: TCP BBR: fix integer overflow (authored by tuexen).
TCP BBR: fix integer overflow
Wed, Feb 5, 8:46 PM
tuexen committed rGc3322bb4680b: TCP BBR: simplify expression (authored by tuexen).
TCP BBR: simplify expression
Wed, Feb 5, 8:45 PM
tuexen committed rG0d93b08b4942: TCP BBR: simplify expression (authored by tuexen).
TCP BBR: simplify expression
Wed, Feb 5, 8:45 PM
tuexen committed rG0450ed7766de: TCP RACK: remove un-needed assignment (authored by tuexen).
TCP RACK: remove un-needed assignment
Wed, Feb 5, 8:45 PM
tuexen committed rG53da007da1fa: TCP RACK: remove un-needed assignment (authored by tuexen).
TCP RACK: remove un-needed assignment
Wed, Feb 5, 8:41 PM
tuexen committed rG6aa2c8ed5eef: TCP RACK: simplify condition (authored by tuexen).
TCP RACK: simplify condition
Wed, Feb 5, 8:40 PM
tuexen committed rGf5203188413a: TCP BBR: do not log an uninitialized value (authored by tuexen).
TCP BBR: do not log an uninitialized value
Wed, Feb 5, 8:38 PM
tuexen committed rG3f45a8ffadad: TCP BBR: do not log an uninitialized value (authored by tuexen).
TCP BBR: do not log an uninitialized value
Wed, Feb 5, 8:37 PM
tuexen committed rG080caa0aea25: TCP RACK: avoid using uninitialized tot_idle variable (authored by tuexen).
TCP RACK: avoid using uninitialized tot_idle variable
Wed, Feb 5, 8:33 PM
tuexen committed rGc8828fec0540: TCP BBR: remove code which is never executed (authored by tuexen).
TCP BBR: remove code which is never executed
Wed, Feb 5, 8:32 PM
tuexen committed rG8a246cebc105: TCP BBR: remove code which is never executed (authored by tuexen).
TCP BBR: remove code which is never executed
Wed, Feb 5, 8:32 PM
tuexen committed rG699d5634661d: TCP BBR: fix condition when sending a tail loss probe (authored by tuexen).
TCP BBR: fix condition when sending a tail loss probe
Wed, Feb 5, 8:31 PM
tuexen committed rG8ef4a2cfb30d: TCP BBR: fix condition when sending a tail loss probe (authored by tuexen).
TCP BBR: fix condition when sending a tail loss probe
Wed, Feb 5, 8:31 PM
tuexen committed rG7db5c08dc637: TCP RACK: add comment (authored by tuexen).
TCP RACK: add comment
Wed, Feb 5, 8:30 PM
tuexen committed rG3520068b471f: TCP RACK: add comment (authored by tuexen).
TCP RACK: add comment
Wed, Feb 5, 8:30 PM
tuexen committed rG1d39f58d735c: TCP BBR: fix getsockopt() for TCP_BBR_USEDEL_RATE (authored by tuexen).
TCP BBR: fix getsockopt() for TCP_BBR_USEDEL_RATE
Wed, Feb 5, 8:28 PM
tuexen committed rGb638491bb878: TCP BBR: fix getsockopt() for TCP_BBR_USEDEL_RATE (authored by tuexen).
TCP BBR: fix getsockopt() for TCP_BBR_USEDEL_RATE
Wed, Feb 5, 7:53 PM
tuexen committed rG8d5e624d8daf: TCP RACK: don't use an uninitialized variable (authored by tuexen).
TCP RACK: don't use an uninitialized variable
Wed, Feb 5, 7:51 PM
tuexen committed rG92d87203c00e: TCP RACK, BBR: cleanup of ctf_process_inbound_raw() (authored by tuexen).
TCP RACK, BBR: cleanup of ctf_process_inbound_raw()
Wed, Feb 5, 7:50 PM
tuexen committed rGdd0d5ece19be: TCP RACK, BBR: cleanup of ctf_process_inbound_raw() (authored by tuexen).
TCP RACK, BBR: cleanup of ctf_process_inbound_raw()
Wed, Feb 5, 7:44 PM
tuexen committed rG60682a028156: TCP RACK, BBR: ensure return value is always ininitialized (authored by tuexen).
TCP RACK, BBR: ensure return value is always ininitialized
Wed, Feb 5, 7:43 PM
tuexen committed rG0da0b392e2e4: TCP RACK, BBR: ensure return value is always ininitialized (authored by tuexen).
TCP RACK, BBR: ensure return value is always ininitialized
Wed, Feb 5, 7:43 PM
tuexen committed rGb9c89008cca9: TCP RACK: remove redundant check (authored by tuexen).
TCP RACK: remove redundant check
Wed, Feb 5, 7:39 PM
tuexen committed rGac863fd8298c: TCP BBR: remove assignments without effect (authored by tuexen).
TCP BBR: remove assignments without effect
Wed, Feb 5, 7:38 PM
tuexen committed rG8ed1a0c91195: TCP BBR: remove assignments without effect (authored by tuexen).
TCP BBR: remove assignments without effect
Wed, Feb 5, 7:37 PM
tuexen committed rG6b8b1047276e: icmp: improve INVARIANTS check (authored by tuexen).
icmp: improve INVARIANTS check
Wed, Feb 5, 6:45 PM
tuexen committed rG6bcc3ae6d61d: icmp.4: improve icmplim and add icmplim_jitter description (authored by tuexen).
icmp.4: improve icmplim and add icmplim_jitter description
Wed, Feb 5, 6:42 PM
tuexen committed rGc8bd4684eb39: icmp.4: improve icmplim and add icmplim_jitter description (authored by tuexen).
icmp.4: improve icmplim and add icmplim_jitter description
Wed, Feb 5, 6:23 PM
tuexen committed rG08398b84ef15: tcp: define tcp_lro_log() only when TCP_BLACKBOX is defined (authored by tuexen).
tcp: define tcp_lro_log() only when TCP_BLACKBOX is defined
Wed, Feb 5, 6:23 PM
tuexen committed rGf9e4eb3e8efc: tcp: fix the initial CWND when a SYN retransmission happened (authored by tuexen).
tcp: fix the initial CWND when a SYN retransmission happened
Wed, Feb 5, 6:00 PM
tuexen committed rGcb9ee81985f2: tcp: fix the initial CWND when a SYN retransmission happened (authored by tuexen).
tcp: fix the initial CWND when a SYN retransmission happened
Wed, Feb 5, 5:59 PM

Mon, Feb 3

tuexen added inline comments to D48804: icmp: use per rate limit randomized jitter.
Mon, Feb 3, 8:03 PM
tuexen added inline comments to D48804: icmp: use per rate limit randomized jitter.
Mon, Feb 3, 8:03 PM
tuexen updated the diff for D48804: icmp: use per rate limit randomized jitter.

Add KASSERT()s, as suggested by glebius@.

Mon, Feb 3, 8:02 PM
tuexen retitled D48804: icmp: use per rate limit randomized jitter from tcp: use per rate limit randomized jitter to icmp: use per rate limit randomized jitter.
Mon, Feb 3, 11:03 AM
tuexen requested review of D48804: icmp: use per rate limit randomized jitter.
Mon, Feb 3, 10:43 AM

Tue, Jan 28

tuexen accepted D48705: Add a kgdb python script to extract bbl from kernel dumps.
Tue, Jan 28, 8:19 PM

Mon, Jan 27

tuexen added a comment to D48652: tcp: revert rxtshift too on a spurious timeout (RTO).

Hi Peter,
thanks for letting us know that one can also trigger these issues with the TCP stress tester. Will try to reproduce it with and without fixing the root cause. There might be more than one problem and I prefer to fix them individually instead of avoiding them altogether...

Mon, Jan 27, 4:44 PM

Fri, Jan 24

tuexen added a comment to D48652: tcp: revert rxtshift too on a spurious timeout (RTO).

Well, if the RTO was indeed spurious, then the subsequent RTO timeout should be the base RTO timeout (again). So, only a false detection of a spurious timeout would (incorrectly) set the cadence to a slightly faster retransmission schedule in subsequent rounds... But if the RTO was spurious, so by definition shouldn't have been triggered anyway, I don't believe this causes a problematic behavior.

Fri, Jan 24, 4:41 PM
tuexen added a comment to D48652: tcp: revert rxtshift too on a spurious timeout (RTO).

Wouldn't be the RTO after an erroneous RTO be computer incorrectly? Let me write a test for that...

Fri, Jan 24, 3:31 PM

Jan 9 2025

tuexen closed D48341: TCP BBR: remove dead code.
Jan 9 2025, 5:30 AM
tuexen committed rGe7fbf52a3e38: TCP BBR: remove dead code (authored by tuexen).
TCP BBR: remove dead code
Jan 9 2025, 5:29 AM

Jan 8 2025

tuexen added a comment to D48346: TCP RACK: don't log an uninitialized value.
In D48346#1103376, @cc wrote:

Why not move the old_method: label above the stack variables' declaration? I think it may be cleaner to read.
Like this:

	old_method:
		uint64_t cwnd, tr_perms = 0;
		int32_t reduce = 0;
Jan 8 2025, 10:20 PM
tuexen closed D48346: TCP RACK: don't log an uninitialized value.
Jan 8 2025, 10:19 PM
tuexen committed rG4c89d59e0cda: TCP RACK: don't log an uninitialized value (authored by tuexen).
TCP RACK: don't log an uninitialized value
Jan 8 2025, 10:19 PM
tuexen updated the diff for D48341: TCP BBR: remove dead code.

Address comment raised by Peter. Coverity also reported it, which I overlooked.

Jan 8 2025, 9:42 PM

Jan 7 2025

tuexen retitled D48346: TCP RACK: don't log an uninitialized value from TCP RACK: don't lock an uninitialized value to TCP RACK: don't log an uninitialized value.
Jan 7 2025, 8:07 AM

Jan 6 2025

tuexen requested review of D48346: TCP RACK: don't log an uninitialized value.
Jan 6 2025, 9:25 PM
tuexen committed rGe8ec28047df5: TCP RACK: fix TCP_RACK_PACING_BETA socket option (authored by tuexen).
TCP RACK: fix TCP_RACK_PACING_BETA socket option
Jan 6 2025, 8:45 PM
tuexen closed D48340: TCP RACK: fix TCP_RACK_PACING_BETA socket option.
Jan 6 2025, 8:44 PM
tuexen requested review of D48341: TCP BBR: remove dead code.
Jan 6 2025, 8:37 PM
tuexen closed D48338: TCP BBR: remove dead code.
Jan 6 2025, 8:28 PM
tuexen committed rG061727efe1e3: TCP BBR: remove dead code (authored by tuexen).
TCP BBR: remove dead code
Jan 6 2025, 8:28 PM
tuexen requested review of D48340: TCP RACK: fix TCP_RACK_PACING_BETA socket option.
Jan 6 2025, 8:24 PM
tuexen requested review of D48338: TCP BBR: remove dead code.
Jan 6 2025, 8:13 PM
tuexen closed D48323: TCP BBR: remove dead code.
Jan 6 2025, 7:43 PM
tuexen committed rGc28fefe1dc44: TCP BBR: remove dead code (authored by tuexen).
TCP BBR: remove dead code
Jan 6 2025, 7:43 PM
tuexen closed D48322: TCP RACK: fix TCP fast open.
Jan 6 2025, 7:41 PM
tuexen committed rGbb9525f30214: TCP RACK: fix TCP fast open (authored by tuexen).
TCP RACK: fix TCP fast open
Jan 6 2025, 7:41 PM

Jan 4 2025

tuexen requested review of D48323: TCP BBR: remove dead code.
Jan 4 2025, 8:52 PM
tuexen requested review of D48322: TCP RACK: fix TCP fast open.
Jan 4 2025, 8:50 PM
tuexen closed D48321: TCP RACK: remove variable with is only initialized and not changed.
Jan 4 2025, 8:15 PM
tuexen committed rG84e894ce1309: TCP RACK: remove variable with is only initialized and not changed (authored by tuexen).
TCP RACK: remove variable with is only initialized and not changed
Jan 4 2025, 8:15 PM
tuexen closed D48320: TCP BBR: remove code not needed.
Jan 4 2025, 8:11 PM
tuexen committed rG4bce1a19fcfa: TCP BBR: remove code which is not needed (authored by tuexen).
TCP BBR: remove code which is not needed
Jan 4 2025, 8:11 PM
tuexen updated the summary of D48321: TCP RACK: remove variable with is only initialized and not changed.
Jan 4 2025, 4:44 PM
tuexen requested review of D48321: TCP RACK: remove variable with is only initialized and not changed.
Jan 4 2025, 3:01 PM