Page MenuHomeFreeBSD

tuexen (Michael Tuexen)
User

Projects

User Details

User Since
Feb 4 2016, 4:45 PM (505 w, 3 d)

Recent Activity

Fri, Oct 10

tuexen committed rGb339da5b23e8: sockstat: support reporting of BBLog state (authored by tuexen).
sockstat: support reporting of BBLog state
Fri, Oct 10, 11:28 AM
tuexen committed rGd46d4628f65d: sockstat: support reporting of BBLog state (authored by tuexen).
sockstat: support reporting of BBLog state
Fri, Oct 10, 11:00 AM

Thu, Oct 9

tuexen requested review of D53005: sockstat: improve handling of path state.
Thu, Oct 9, 9:31 PM
tuexen committed rG746eadecaa7d: sockstat: show path state column only when useful (authored by tuexen).
sockstat: show path state column only when useful
Thu, Oct 9, 7:19 PM
tuexen closed D52986: sockstat: show path state column only when useful.
Thu, Oct 9, 7:19 PM
tuexen committed rG98b2a2265f5e: sockstat: improve output formatting (authored by tuexen).
sockstat: improve output formatting
Thu, Oct 9, 7:14 PM
tuexen closed D52984: sockstat: improve output formatting.
Thu, Oct 9, 7:14 PM
tuexen added a comment to D52989: tcp lro: use flowid only when it has hash properties.

Also, this needs to be MFC'ed to 15 for the release..

Thu, Oct 9, 1:13 PM
tuexen committed rG4774687d4087: tcp lro: use the flowid only when it has hash properties (authored by tuexen).
tcp lro: use the flowid only when it has hash properties
Thu, Oct 9, 1:11 PM
tuexen committed rG73f56fa542ec: tcp lro: use theflowid only when it has hash properties (authored by tuexen).
tcp lro: use theflowid only when it has hash properties
Thu, Oct 9, 1:02 PM
tuexen closed D52989: tcp lro: use flowid only when it has hash properties.
Thu, Oct 9, 1:02 PM
tuexen accepted D52989: tcp lro: use flowid only when it has hash properties.
Thu, Oct 9, 12:53 PM
tuexen added a comment to D52984: sockstat: improve output formatting.

Could you please give an example of the before and after output?

Thu, Oct 9, 12:24 PM
tuexen added a comment to D52986: sockstat: show path state column only when useful.

Could you give an example of what the output looks like before and after?

Thu, Oct 9, 12:22 PM
tuexen committed rG3ca54c736b9c: tcp: remove stray ; (authored by tuexen).
tcp: remove stray ;
Thu, Oct 9, 8:01 AM
tuexen committed rG41e9c68d9ac1: tcp: improve SEG.ACK validation in SYN-RECEIVED (authored by tuexen).
tcp: improve SEG.ACK validation in SYN-RECEIVED
Thu, Oct 9, 8:00 AM
tuexen committed rG3b6fb75bdece: tcp: remove stray ; (authored by tuexen).
tcp: remove stray ;
Thu, Oct 9, 8:00 AM
tuexen committed rG087fc6ae0a8c: tcp: remove stray ; (authored by tuexen).
tcp: remove stray ;
Thu, Oct 9, 7:55 AM
tuexen committed rG1728dae25358: tcp: improve SEG.ACK validation in SYN-RECEIVED (authored by tuexen).
tcp: improve SEG.ACK validation in SYN-RECEIVED
Thu, Oct 9, 7:55 AM
tuexen committed rGb177df181541: tcp: remove stray ; (authored by tuexen).
tcp: remove stray ;
Thu, Oct 9, 7:54 AM
tuexen requested review of D52989: tcp lro: use flowid only when it has hash properties.
Thu, Oct 9, 7:49 AM

Wed, Oct 8

tuexen added a reviewer for D52984: sockstat: improve output formatting: rrs.
Wed, Oct 8, 7:55 PM
tuexen requested review of D52986: sockstat: show path state column only when useful.
Wed, Oct 8, 7:54 PM
tuexen requested review of D52984: sockstat: improve output formatting.
Wed, Oct 8, 7:26 PM
tuexen committed rGab837a2eed6d: sockstat: improve indentation (authored by tuexen).
sockstat: improve indentation
Wed, Oct 8, 6:31 PM
tuexen requested review of D52979: tcp: Initial ktest for HPTS.
Wed, Oct 8, 11:27 AM

Tue, Oct 7

tuexen committed rGd801cc2d8542: sockstat: support reporting of BBLog state (authored by tuexen).
sockstat: support reporting of BBLog state
Tue, Oct 7, 6:38 PM
tuexen closed D52944: sockstat: support reporting of BBLog state.
Tue, Oct 7, 6:38 PM

Mon, Oct 6

tuexen requested review of D52948: tcp: cleanup of syncache_expand().
Mon, Oct 6, 10:07 PM
tuexen added a comment to D52934: tcp: improve SEG.ACK validation in SYN-RECEIVED.

I can confirm that this fixes the crash I've seen. Instead of crashing after a few minutes, it now is still humming happily with 16 minutes of uptime.

Mon, Oct 6, 9:37 PM
tuexen committed rG0faa9ca827a5: tcp: remove stray ; (authored by tuexen).
tcp: remove stray ;
Mon, Oct 6, 9:36 PM
tuexen committed rG8af2f06a99b1: tcp: improve SEG.ACK validation in SYN-RECEIVED (authored by tuexen).
tcp: improve SEG.ACK validation in SYN-RECEIVED
Mon, Oct 6, 8:44 PM
tuexen closed D52934: tcp: improve SEG.ACK validation in SYN-RECEIVED.
Mon, Oct 6, 8:44 PM
tuexen requested review of D52944: sockstat: support reporting of BBLog state.
Mon, Oct 6, 8:37 PM
tuexen updated the diff for D52934: tcp: improve SEG.ACK validation in SYN-RECEIVED.

Address one of Jonathan's comments.

Mon, Oct 6, 3:54 PM
tuexen added inline comments to D52934: tcp: improve SEG.ACK validation in SYN-RECEIVED.
Mon, Oct 6, 3:54 PM
tuexen retitled D52934: tcp: improve SEG.ACK validation in SYN-RECEIVED from tcp: improve SEG.ACK check in SYN-RECEIVED to tcp: improve SEG.ACK validation in SYN-RECEIVED.
Mon, Oct 6, 2:49 PM
tuexen requested review of D52934: tcp: improve SEG.ACK validation in SYN-RECEIVED.
Mon, Oct 6, 2:42 PM
tuexen committed rG941b8ecdc087: tcp: remove stray ; (authored by tuexen).
tcp: remove stray ;
Mon, Oct 6, 2:34 PM

Sun, Oct 5

tuexen committed rGf846f0cc6002: tcp: improve segment validation in SYN-RECEIVED (authored by tuexen).
tcp: improve segment validation in SYN-RECEIVED
Sun, Oct 5, 1:32 PM
tuexen committed rG81ea2bdab13b: tcp: keep SYN-cache entry when sending of challenge ACK fails (authored by tuexen).
tcp: keep SYN-cache entry when sending of challenge ACK fails
Sun, Oct 5, 1:31 PM
tuexen committed rG0ca910a682c3: tcp: cleanup syncache_expand() (authored by tuexen).
tcp: cleanup syncache_expand()
Sun, Oct 5, 1:30 PM
tuexen committed rGa7dcd4c2a9fb: tcp: improve segment validation in SYN-RECEIVED (authored by tuexen).
tcp: improve segment validation in SYN-RECEIVED
Sun, Oct 5, 1:26 PM
tuexen committed rGb0501abb4cfb: tcp: cleanup syncache_expand() (authored by tuexen).
tcp: cleanup syncache_expand()
Sun, Oct 5, 1:25 PM
tuexen committed rGb7b48ba8420f: tcp: keep SYN-cache entry when sending of challenge ACK fails (authored by tuexen).
tcp: keep SYN-cache entry when sending of challenge ACK fails
Sun, Oct 5, 1:20 PM

Sat, Oct 4

tuexen added a reviewer for D52771: socket(2): refactor the manual page: tuexen.
Sat, Oct 4, 5:52 AM

Fri, Oct 3

tuexen committed rG0cd22970019e: tcp: apply rate limits to challenge ACKs (authored by tuexen).
tcp: apply rate limits to challenge ACKs
Fri, Oct 3, 8:39 AM
tuexen committed rGe1a7840dd941: vtnet: disable hardware TCP LRO by default (authored by tuexen).
vtnet: disable hardware TCP LRO by default
Fri, Oct 3, 8:38 AM
tuexen committed rGc55c8a899edc: tcp: apply rate limits to challenge ACKs (authored by tuexen).
tcp: apply rate limits to challenge ACKs
Fri, Oct 3, 8:32 AM
tuexen committed rG3d548504c705: vtnet: disable hardware TCP LRO by default (authored by tuexen).
vtnet: disable hardware TCP LRO by default
Fri, Oct 3, 8:32 AM

Thu, Oct 2

tuexen added a comment to D52872: tcp: bump max snd buffer size for autoscaling.
In D52872#1207881, @jtl wrote:

Is this worthy of a release note?

Thu, Oct 2, 8:57 PM
tuexen requested review of D52873: sockets: bump socket buffer limit.
Thu, Oct 2, 7:58 PM
tuexen retitled D52872: tcp: bump max snd buffer size for autoscaling from tcp: bump max rcv buffer size for autoscaling to tcp: bump max snd buffer size for autoscaling.
Thu, Oct 2, 7:57 PM
tuexen accepted D52868: tcp: close two minor races with debug messages.
Thu, Oct 2, 7:33 PM
tuexen requested review of D52872: tcp: bump max snd buffer size for autoscaling.
Thu, Oct 2, 7:31 PM
tuexen requested review of D52871: tcp: bump max rcv buffer size for autoscaling.
Thu, Oct 2, 7:29 PM
tuexen committed rGb7118461f909: tcp: improve segment validation in SYN-RECEIVED (authored by tuexen).
tcp: improve segment validation in SYN-RECEIVED
Thu, Oct 2, 2:55 PM
tuexen closed D52849: tcp: improve segment validation in SYN-RECEIVED.
Thu, Oct 2, 2:54 PM
tuexen requested review of D52849: tcp: improve segment validation in SYN-RECEIVED.
Thu, Oct 2, 7:59 AM
tuexen committed rG7841b44f8491: tcp: keep SYN-cache entry when sending of challenge ACK fails (authored by tuexen).
tcp: keep SYN-cache entry when sending of challenge ACK fails
Thu, Oct 2, 7:00 AM
tuexen closed D52840: tcp: keep SYN-cache entry when sending of challenge ACK fails.
Thu, Oct 2, 7:00 AM

Wed, Oct 1

tuexen requested review of D52840: tcp: keep SYN-cache entry when sending of challenge ACK fails.
Wed, Oct 1, 8:55 PM
tuexen committed rG3034fa3d4321: tcp: cleanup syncache_expand() (authored by tuexen).
tcp: cleanup syncache_expand()
Wed, Oct 1, 7:18 PM
tuexen closed D52816: tcp: cleanup syncache_expand().
Wed, Oct 1, 7:17 PM
tuexen added a comment to D52816: tcp: cleanup syncache_expand().

I agree with Nick that previous comments were better.

I can expand the variable names. But I would like to be consistent in stating what is tested: in one test SEG.SEQ, and in the other SEG.ACK.

You may add assertions that match the checks in the syncookie_expand() case.

I will take this into account when the code is doing the actions it should.

Also, I'm not sure "not a functional change" applies in the commit message. TCP wise there is no change, but code wise there is.

That is not there anymore...

P.S. Interesting that the email generator of phabricator produced a much easier diff to read than the web version.

I totally agree....

Wed, Oct 1, 3:11 PM
tuexen added a comment to D52816: tcp: cleanup syncache_expand().

This change looks good to me, though I personally prefer to the more verbose comments before you shortened them. But I wouldn't block on that.

OK. Moving the checks to the proper place is the first step. The second step will be to do the right action, which is sending a challenge ACK instead of killing the entry. When writing the comments for the second step, I will expand the variable names again.

One comment about the preexisting pattern here: requiring every failure path to individually unlock is error prone IMHO, as well as having a mix of return and goto. There's already a locked variable too. I don't think a single exit point with the cleanup would be too hard to add... just a thought.

Once we have the right functionality, we can cleanup the function. I just did not wanted to mix these things up.

Wed, Oct 1, 3:08 PM
tuexen updated the summary of D52816: tcp: cleanup syncache_expand().
Wed, Oct 1, 9:02 AM
tuexen requested review of D52816: tcp: cleanup syncache_expand().
Wed, Oct 1, 9:01 AM
tuexen committed rGa98b5f3ff34e: vtnet: improve control of transmit offloading (authored by tuexen).
vtnet: improve control of transmit offloading
Wed, Oct 1, 7:37 AM
tuexen committed rGbd7f55a1d815: vtnet: improve control of transmit offloading (authored by tuexen).
vtnet: improve control of transmit offloading
Wed, Oct 1, 7:33 AM

Tue, Sep 30

tuexen committed rGc2900b6e8255: tcp: apply rate limits to challenge ACKs (authored by tuexen).
tcp: apply rate limits to challenge ACKs
Tue, Sep 30, 8:09 PM
tuexen closed D52754: tcp: apply rate limits to challenge ACKs.
Tue, Sep 30, 8:09 PM
tuexen added inline comments to D52754: tcp: apply rate limits to challenge ACKs.
Tue, Sep 30, 5:26 PM
tuexen committed rG6e4b811009d6: vtnet: disable hardware TCP LRO by default (authored by tuexen).
vtnet: disable hardware TCP LRO by default
Tue, Sep 30, 5:15 PM
tuexen closed D52684: vtnet: disable hardware TCP LRO by default.
Tue, Sep 30, 5:15 PM

Mon, Sep 29

tuexen committed rGfed8dbe794a6: vtnet: improve interface capability handling (authored by tuexen).
vtnet: improve interface capability handling
Mon, Sep 29, 7:51 PM
tuexen committed rG503bf058cd0a: epair: add support for checksum offloading (authored by timo.voelker_fh-muenster.de).
epair: add support for checksum offloading
Mon, Sep 29, 7:44 PM
tuexen committed rGc0598ba49d2c: vtnet: improve interface capability handling (authored by tuexen).
vtnet: improve interface capability handling
Mon, Sep 29, 7:43 PM

Sun, Sep 28

tuexen committed rG5e4bed48699a: tcp: refactor tcp_send_challenge_ack() (authored by tuexen).
tcp: refactor tcp_send_challenge_ack()
Sun, Sep 28, 9:18 AM
tuexen committed rG994b3f20900d: tcp: whitespace cleanup (authored by tuexen).
tcp: whitespace cleanup
Sun, Sep 28, 9:17 AM
tuexen committed rG125e23572c71: tcp: refactor tcp_send_challenge_ack() (authored by tuexen).
tcp: refactor tcp_send_challenge_ack()
Sun, Sep 28, 9:10 AM
tuexen committed rGcfda7828e33d: tcp: whitespace cleanup (authored by tuexen).
tcp: whitespace cleanup
Sun, Sep 28, 9:10 AM
tuexen committed rGf2575d56c8c9: vtnet: improve control of transmit offloading (authored by tuexen).
vtnet: improve control of transmit offloading
Sun, Sep 28, 9:07 AM
tuexen closed D52765: vtnet: improve control of transmit offloading.
Sun, Sep 28, 9:07 AM

Sat, Sep 27

tuexen updated the summary of D52765: vtnet: improve control of transmit offloading.
Sat, Sep 27, 7:51 PM
tuexen requested review of D52765: vtnet: improve control of transmit offloading.
Sat, Sep 27, 7:50 PM

Fri, Sep 26

tuexen requested review of D52754: tcp: apply rate limits to challenge ACKs.
Fri, Sep 26, 8:02 PM
tuexen accepted D52751: arm64: Add table attributes to the EFI maps.

I tested this patch in combination with D52750 and it resolves the issue. Thanks for the fix.

Fri, Sep 26, 1:45 PM
tuexen accepted D52750: arm64: Mark EFI memory as userspace non-executable.

I tested this patch in combination with D52751 and it resolves the issue. Thanks for the fix.

Fri, Sep 26, 1:44 PM
tuexen committed rGeaf619fddcb2: vtnet: improve interface capability handling (authored by tuexen).
vtnet: improve interface capability handling
Fri, Sep 26, 11:43 AM
tuexen closed D52682: vtnet: improve interface capability handling.

Committed in eaf619fddcb2.

Fri, Sep 26, 11:19 AM
tuexen committed rG4010352306ef: tcp lro: remove redundant check (authored by tuexen).
tcp lro: remove redundant check
Fri, Sep 26, 10:35 AM
tuexen committed rG3f87b632ed04: tcp: fix sending of RST segments (authored by tuexen).
tcp: fix sending of RST segments
Fri, Sep 26, 10:35 AM
tuexen committed rGccbc5f307a66: tcp lro: remove redundant check (authored by tuexen).
tcp lro: remove redundant check
Fri, Sep 26, 10:35 AM
tuexen committed rGa41b0e52ab90: tcp: fix sending of RST segments (authored by tuexen).
tcp: fix sending of RST segments
Fri, Sep 26, 10:35 AM

Thu, Sep 25

tuexen committed rGdb37256ce543: tcp: refactor tcp_send_challenge_ack() (authored by tuexen).
tcp: refactor tcp_send_challenge_ack()
Thu, Sep 25, 7:05 PM
tuexen committed rG40417930f6ba: tcp: whitespace cleanup (authored by tuexen).
tcp: whitespace cleanup
Thu, Sep 25, 7:05 PM
tuexen added reviewers for D51289: tuntap: add SIOCGIFCAP and SIOCSIFCAP ioctls: ae, melifaro.
Thu, Sep 25, 6:51 PM
tuexen closed D52717: tcp: refactor tcp_send_challenge_ack().

Committed in db37256ce543

Thu, Sep 25, 6:45 PM
tuexen added inline comments to D52682: vtnet: improve interface capability handling.
Thu, Sep 25, 6:34 PM